1657979 - make test_bug277724.html to pass on Fission

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Session history blocks our Nightly experiment so tracking session history test failures for Fission Nightly milestone M6b.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

./mach mochitest --setpref="fission.sessionHistoryInParent=true" --enable-xorigin-tests --enable-fission dom/html/test/test_bug277724.html yields:

0:49.63 TEST_START: http://mochi.test:8888/tests/dom/html/test/test_bug277724.html
 0:50.66 GECKO(11766) [Child 11935, Main Thread] WARNING: NS_ENSURE_TRUE(mRequest) failed: file /home/mirko/src/firefox/gecko2/netwerk/base/nsBaseChannel.cpp, line 925
 0:52.41 GECKO(11766) [12097, Unnamed thread 7f9d6648b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:52.41 GECKO(11766) ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpMJh_A5.mozrunner/runtests_leaks.log
 0:52.41 GECKO(11766) [12097, Unnamed thread 7f9d6648b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:52.41 GECKO(11766) [12097, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /home/mirko/src/firefox/gecko2/tools/profiler/core/platform.cpp, line 246
 0:53.94 GECKO(11766) [Child 11988, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp, line 241
 0:53.94 GECKO(11766) [Child 11988, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp, line 241
 0:54.05 GECKO(11766) [Parent 11766, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp, line 407
 0:55.16 PASS Child not unloaded yet

[...]

 0:56.42 PASS Unload handler should have fired
 0:56.43 GECKO(11766) Assertion failure: mRawPtr != nullptr (You can't dereference a NULL nsCOMPtr with operator->().), at /home/mirko/src/firefox/gecko2/xpcom/base/nsCOMPtr.h:859
Initializing stack-fixing for the first stack frame, this may take a while...

Hence, this is a bug in Gecko, not in the test-code.

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

shistory is nullptr in ChildSHistory::Go. Hence, presumably fixed in bug 1662410.

Comment 4

[Jens Stutte [:jstutte]]

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

Comment 5

[Andreas Farre [:farre]]

With the fix for bug 1662410 this doesn't crash, but it doesn't finish.

Comment 6

[Neha Kochar [:neha]]

(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #4)

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

Same as Bug 1657982 Comment 4.

Comment 7

[Neha Kochar [:neha]]

Although the dependency is on the fix of bug 1662410, it really won't take effect with fission until session history pref is enabled with fission(bug fission-history-m6b).

Comment 8

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

 0:54.34 PASS button should be null
 0:55.02 GECKO(6342) [Parent 6342, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 0:55.02 GECKO(6342) [Parent 6342, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 0:55.03 GECKO(6342) [Parent 6342, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 1:04.75 GECKO(6342) [Parent 6342, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 1:04.75 GECKO(6342) [Parent 6342, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 1:04.76 GECKO(6342) [Parent 6342, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503

Test doesn't finish.

Comment 9

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1657979: don't skip "test_bug277724.html" for Fission. r=smaug

Because it passes and finishes now.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7129cad8caa3
don't skip "test_bug277724.html" for Fission. r=smaug

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7129cad8caa3