[Doorhanger V2] Add telemetry event for username/password edits in the doorhanger
Categories
(Toolkit :: Password Manager, task, P2)
Tracking
()
People
(Reporter: severin, Assigned: severin)
References
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
ryanvm
:
approval-mozilla-beta+
|
Details | Review |
2.66 KB,
text/plain
|
tdsmith
:
data-review+
|
Details |
Add telemetry that reports how frequently PM doorhanger information is edited, to support our OKR of improving our recommended values.
Requirements
- When the user selects 'save' or 'update', send an event with booleans 'did_edit_un' and 'did_edit_pw'
- Typing or pasting into a field should set the
did_edit_*
boolean state to true - State should be reset for each doorhanger instance
- No ID (or other information that could be correlated to a user) should be sent
Verification notes
- Can be verified locally in
about:telemetry
(There are some edge cases that affect whenabout:telemetry
gets updated. You probably know more about this than I do, but if not feel free to reach out.) - The event will be called
doorhanger_submitted
. See its definition for details - Ensure that the
extra_keys
did_edit_un
anddid_edit_pw
match user behavior - Ensure that the sent
object
(save
orupdate
) matches the original state when the doorhanger was created (this will not change if the user modifies the doorhanger fields) - Ensure that exactly 1 event is sent every time the doorhanger is either saved or updated
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
•
|
||
Comment on attachment 9161785 [details]
Bug 1650929 - add 'pwmgr doorhanger modified' telemetry; r=MattN
Beta/Release Uplift Approval Request
- User impact if declined: No user impact (MattN addition: we won't be able to measure the impact of our doorhanger v2 improvements)
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a telemetry only change. It is very low risk, and should be transparent to the user.
We have no alternative to uplifting this if we want to establish baseline numbers for one of our OKRs.
- String changes made/needed: None
Updated•5 years ago
|
Comment 6•5 years ago
|
||
bugherder |
Comment 7•5 years ago
|
||
Have we verified that the incoming Telemetry data from Nightly looks sane so far?
Comment 8•5 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
Have we verified that the incoming Telemetry data from Nightly looks sane so far?
Comment 9•5 years ago
|
||
Comment on attachment 9161785 [details]
Bug 1650929 - add 'pwmgr doorhanger modified' telemetry; r=MattN
Thanks for the confirmation. Approved for 79.0 RC1.
Comment 10•5 years ago
|
||
bugherder uplift |
Assignee | ||
Comment 11•5 years ago
|
||
I updated the comment 0 with verification details. LMK if any of it could use clarification.
Comment 12•5 years ago
|
||
Hey Severin,
I am getting "did_edit_un:true" for Save and Update doorhanger for when I select an option from the username autocomplete dropdown, the following 2 scenarios are not ok at this moment:
Open doorhanger -> select autocomplete value -> save == did_edit_un: false | Recording of the issue: https://streamable.com/hhblod
Open doorhanger -> modify username -> select autocomplete value -> save == did_edit_un: false | Recording of the issue: https://streamable.com/n8da95
Same goes for the Update scenarios.
Assignee | ||
Comment 13•5 years ago
|
||
That's my bad Timea, I conflated two bugs when I described those cases to you. These two cases won't need to be valid until bug 1650941 lands, which will update the telemetry to account for the new autocomplete functionality.
Comment 14•5 years ago
|
||
No worries, I also missed to see Bug 1650941 to figure it out on my own.
Verified-fixed on latest Firefox Nightly 80 and Beta 79 on Windows 10, MacOS and Ubuntu 16.04 for the cases where we manually edit the username or password.
Description
•