1651880 - Cleanup Stencil structs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Tooru Fujisawa [:arai]]

as a followup for bug 1641202

• remove/merge duplicate fields
• simplify code flow
• move functions to appropriate file

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 1: Use CompilationInfo.enclosingScope for all context. r?tcampbell!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 2: Use FunctionFlags instead of isAsmJSModule field. r?tcampbell!

Depends on D83071

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 3: Move AbstractScopePtr::getOrCreateScope to ScopeCreationData. r?tcampbell!

Depends on D83072

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 4: Remove stale comments. r?tcampbell!

Depends on D83073

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 5: Move stencil instantiation into Stencil.cpp. r?tcampbell!

Depends on D83074

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 6: Remove stale comment about SourceExtent. r?tcampbell!

Depends on D83075

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 7: Use FunctionFlags for detecting function. r?tcampbell!

Depends on D83076

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 8: Do not copy script fields for asm.js function. r?tcampbell!

Depends on D83077

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 9: Add category comment for ScriptStencil fields. r?tcampbell!

Depends on D83078

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 10: Remove wrong comment. r?tcampbell!

Depends on D83079

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1651880 - Part 11: Instantiate ScopeCreationData in top down way. r?tcampbell!

Depends on D83080

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/982bc626b765
Part 1: Use CompilationInfo.enclosingScope for all context. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/6f581bd3c43c
Part 2: Use FunctionFlags instead of isAsmJSModule field. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c67f2e089773
Part 3: Move AbstractScopePtr::getOrCreateScope to ScopeCreationData. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/4b5b4a90c15a
Part 4: Remove stale comments. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5af2cd5c0921
Part 5: Move stencil instantiation into Stencil.cpp. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/578888abdbce
Part 6: Remove stale comment about SourceExtent. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/80b0b41be964
Part 7: Use FunctionFlags for detecting function. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/64823609cb38
Part 8: Do not copy script fields for asm.js function. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8c2780314483
Part 9: Add category comment for ScriptStencil fields. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b761532d2d90
Part 10: Remove wrong comment. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/53f52f397b54
Part 11: Instantiate ScopeCreationData in top down way. r=tcampbell

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/982bc626b765
https://hg.mozilla.org/mozilla-central/rev/6f581bd3c43c
https://hg.mozilla.org/mozilla-central/rev/c67f2e089773
https://hg.mozilla.org/mozilla-central/rev/4b5b4a90c15a
https://hg.mozilla.org/mozilla-central/rev/5af2cd5c0921
https://hg.mozilla.org/mozilla-central/rev/578888abdbce
https://hg.mozilla.org/mozilla-central/rev/80b0b41be964
https://hg.mozilla.org/mozilla-central/rev/64823609cb38
https://hg.mozilla.org/mozilla-central/rev/8c2780314483
https://hg.mozilla.org/mozilla-central/rev/b761532d2d90
https://hg.mozilla.org/mozilla-central/rev/53f52f397b54