1652641 - tab context menu when multiple tabs are selected has menu items with conflicting accelerator keys

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Cameron McCormack (:heycam)]

If you have multiple tabs selected, both the "Select All Tabs" and the "Close Tabs" menu items have "s" as their accelerator key. Can the "Close Tabs" menu item be changed to use "c", to be consistent with the "Close Tab" menu item when only one tab is selected?

Comment 1

[Mike Hommey [:glandium]]

It's "S" presumably because it used to be Close Selected Tabs, which was changed to Close Tabs in bug 1496091. It's also two items, one of which is hidden, I'm not sure we can use the same accesskey without tweaking it in the code that switches between the items. https://searchfox.org/mozilla-central/rev/89814940895946b48b4c04c702efd2c676ec8e7e/browser/base/content/tabbrowser.js#6590

Comment 2

[Mike Hommey [:glandium]]

BTW, I'm not sure the change in bug 1496091 was the right one, especially after bug 887515, and considering languages without plural. Because in a language without plural, there now is "Close multiple tab" and "Close tab", the latter of which is the one that closes the multiple selected tabs... Maybe an additional "Close selected tabs" item under the "Close multiple tabs" menu would help.

Comment 3

[Mike Hommey [:glandium]]

Or maybe in languages without plural, the translation should be that of "Close selected tabs" rather than of "Close tabs", so that it differs from the singular case.

Comment 4

[Dão Gottwald [:dao]]

Gijs, since Jared is on PTO, do you have thoughts on this?

Comment 5

[:Gijs (he/him)]

(In reply to Mike Hommey [:glandium] from comment #2)

BTW, I'm not sure the change in bug 1496091 was the right one, especially after bug 887515, and considering languages without plural. Because in a language without plural, there now is "Close multiple tab" and "Close tab", the latter of which is the one that closes the multiple selected tabs... Maybe an additional "Close selected tabs" item under the "Close multiple tabs" menu would help.

Please file a separate bug if you think there need to be different items in the submenu, or re-labeling of items (perhaps the submenu should be labeled "Close other tabs", to make it clear what the difference is with the selected tab(s), and then the submenu item to close all but the selected tab should be called "Close all other tabs" vs. the other close to the left / close to the right items?)

Either way it seems like that's not really part of the same issue raised in comment #0 (though related), which is clearly defined and can be solved irrespective of what happens to that submenu.

Comment 6

[:Gijs (he/him)]

Attachment: Bug 1652641 - use consistent access key for tab context menu's items to close 1 tab or selected tabs, r?dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/703fa1371dd4
use consistent access key for tab context menu's items to close 1 tab or selected tabs, r=dao,fluent-reviewers,flod

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_multiselect_tabs_close.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1d77f0ca9812adeb18c574b5293e31ad45843e4e
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310387775&repo=autoland&lineNumber=1825

Comment 9

[:Gijs (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=011c018241928fa1bc8b2cdd7041d7b05063cf31

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0ed5585b6ad
use consistent access key for tab context menu's items to close 1 tab or selected tabs, r=dao,fluent-reviewers,flod

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f0ed5585b6ad

Comment 12

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 10 x64 and Ubuntu 18.04 using Firefox 80 Beta 6 (buildID: 20200807195315): "Selected All Tabs" has "s" as accelerator key and "Close Tabs" has "c" as accelerator key.