1653057 - Enable browser_webconsole_requestStorageAccess_errors.js and browser_webconsole_warning_group_storage_isolation.js on Windows

Status: RESOLVED DUPLICATE of bug 1765369

(Core :: Privacy: Anti-Tracking, task, P3)

Description

[Dimi Lee [:dimi]]

browser_webconsole_requestStorageAccess_errors.js is temporarily disabled in Windows because it can't pass leakcheck.
Note that this is not related to the implementation in Bug 1645234.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

browser_webconsole_warning_group_storage_isolation.js is also causing an extremely similar leak (fewer bytes though)

Comment 2

[Chris Peterson [:cpeterson]]

These tests are still skipped:

https://searchfox.org/mozilla-central/rev/a166f59fba89fc70ebfab287f4edb8e05ed4f6da/devtools/client/webconsole/test/browser/_webconsole.ini#353-356

[browser_webconsole_requestStorageAccess_errors.js]
skip-if =
  os == 'win' && debug) #Bug 1653057
  win10_2004 # Bug 1723573

https://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser/_webconsole.ini#413-414

[browser_webconsole_warning_group_storage_isolation.js]
skip-if = fission || (os == 'win' && debug) # Bug 1654522, 1653057

Comment 3

[Alexandre Poirot [:ochameau]]

browser_webconsole_warning_group_storage_isolation.js fails on fission for the same reason as bug 1535451, so I'll try to remove the skip-if=fission there.

Otherwise I tried to look into the leaks coming from these two tests without being able to figure them out.
Dimi, do you have any idea why we would leak something in these two tests?

Comment 4

[Dimi Lee [:dimi]]

(In reply to Alexandre Poirot [:ochameau] from comment #3)

Dimi, do you have any idea why we would leak something in these two tests?

Unfortunately, No, I haven't spent time looking into this issue. If this is something we want to fix soon, maybe we should ask :tim to help re-prioritize this bug.