1601891 - [meta] Enable the devtools tests that were disabled because of Fission

Status: NEW

(DevTools :: General, task, P3)

Description

[Patrick Brosset <:pbro>]

A bunch of tests needed to be disabled in devtools because of fission. Here is the list:
https://searchfox.org/mozilla-central/search?q=fission&case=false&regexp=false&path=devtools%2F**%2Fbrowser.ini

We should track re-enabling these tests. This is the bug for it.

This might need to become a meta-bug, with only dependencies to other bugs.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 2

[Chris Peterson [:cpeterson]]

Adding dt-fission whiteboard tag to DevTools bugs that mention Fission or block Fission meta bugs but don't already have a dt-fission whiteboard tag.

Comment 3

[Chris Peterson [:cpeterson]]

Fixing and re-enabling DevTools Fission tests should block enabling Fission in Nightly.

Comment 4

[Chris Peterson [:cpeterson]]

Moving dt-fission bugs to Fission MVP.

Comment 5

[Neha Kochar [:neha]]

Bulk change of all bugs with whiteboard tag of dt-fission to Fission MVP milestone.

Comment 6

[Julian Descottes [:jdescottes]]

Looks like we still have 30 tests disabled for fission:
https://searchfox.org/mozilla-central/search?q=if%5Cs*%5C%3D.*fission&path=devtools%2F**%2Fbrowser.ini&case=false&regexp=true
(includes fail-if & skip-if)

Comment 7

[Alexandre Poirot [:ochameau]]

Bug 1643717 may contain valuable info/bug dependencies. Where we would probably have to fix the intermittent we disabled there.

Comment 8

[Chris Peterson [:cpeterson]]

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Link from Comment 6 wasn't including webconsole tests, here's a fixed link: https://searchfox.org/mozilla-central/search?q=if%5Cs*%5C%3D%5B%5E%21%5D*fission&path=devtools%2F**%2F*.ini&case=false&regexp=true

So we have 37 occurences. I'm going to go over them, see if they're still need to be skipped, and for existing intermittents (i.e. even without fission), block this bug with the intermittent bug if there's one (or file it).

(Bug 1675020#c1 is quite helpful as it includes a summary of the failure, and a reference to the intermittent bug when there's one)

Comment 10

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp test and infrastructure bugs for Fission M8 (blocking Release experiment).

Comment 11

[Chris Peterson [:cpeterson]]

This bug is assigned to Fission Milestone M8, but has whiteboard tag dt-fission instead of dt-fission-m3-mvp.

I'm adding the dt-fission-m3-triage tag so DevTools Fission triage can decide whether this bug should be fixed for dt-fission-m3-mvp or can be postponed from Fission Milestone MVP to Future.

Comment 12

[Marco Mucci [:MarcoM]]

Removing triage whiteboard tag as meta bugs are not included as part of the project's MVP backlog. If there are individual dependencies which should be considered the whiteboard tag can be added to them.

Comment 13

[Alexandre Poirot [:ochameau]]

Summary of the tests still disabled on fission:

• devtools/client/debugger/test/mochitest/browser_dbg-browser-toolbox-workers.js (intermittent disabled a while back in bug 1675020)
• devtools/client/webconsole/test/browser/browser_webconsole_trackingprotection_errors.js (intermittent disabled in bug 1535451 a while ago)
• devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js (See bug 1654522 and bug 1653057)
• devtools/client/framework/test/browser_toolbox_frames_list.js (fail-if introduced in bug 1608054, related to the iframe picker not supporting fission frames. To be fixed in bug 1608054)

The first three require dedicated investigation, while the last is blocked on bug 1608054.

Comment 14

[Alexandre Poirot [:ochameau]]

It looks like there is only one test left still disabled on fission, browser_dbg-browser-toolbox-workers.js, bug 1685412:
https://searchfox.org/mozilla-central/search?q=skip-if.*fission&path=devtools&case=true&regexp=true

Which may be related to implement both bug 1651518 and 1651522.