Open Bug 1653457 Opened 5 months ago Updated 1 month ago

Fix failing DOM:UI Events & Focus mochitests with cross-origin and Fission enabled

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

defect

Tracking

()

Fission Milestone M6c

People

(Reporter: neha, Assigned: edgar)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: leave-open)

Attachments

(4 files, 1 obsolete file)

These tests are marked as skipped/failed for cross-origin and Fission, and need to be fixed
dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
dom/events/test/test_bug238987.html
dom/events/test/test_bug450876.html
dom/events/test/test_bug741666.html
toolkit/content/tests/widgets/test_mousecapture_area.html

https://docs.google.com/spreadsheets/d/16G5AZhHWWow3rBgim4QBHzWXMIIJiky2SzXYgDMTTKY/edit#gid=1354562828&range=44:49

More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests

Fission Milestone: --- → M6b

Also, dom/events/test/pointerevents/test_trigger_popup_by_pointer_events.html is failing only when Fission is explicitly disabled so this test passing when Fission is enabled might be a false positive and needs to be looked into.

Severity: -- → S3
Priority: -- → P3

Edgar, can you start to look into some of these?

Flags: needinfo?(echen)

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)

Edgar, can you start to look into some of these?

Sure thing, take this bug.

Assignee: nobody → echen
Flags: needinfo?(echen)
Keywords: leave-open
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/343e0c4bd424
Enable dom/events/test/test_bug741666.html on fission and cross-origin; r=smaug DONTBUILD
Depends on: 1658055
Depends on: 1658936
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c945ea0c61d
Enable dom/events/test/pointerevents/test_touch_action.html on fission and cross-origin; r=smaug DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/cb8d53bf489f
Enable dom/events/test/test_bug1581192.html on fission and cross-origin; r=smaug DONTBUILD
Depends on: 1659221
Depends on: 1659494

Remaining tests,

  • dom/events/test/test_bug238987.html
  • dom/events/test/test_bug409604.html
  • dom/events/test/test_bug450876.html
  • dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
Attachment #9168730 - Attachment is obsolete: true

(In reply to Edgar Chen [:edgar] from comment #12)

  • dom/events/test/test_bug238987.html

Test got unexpected focus event for first tab navigation. Look like focus handling goes wrong on OOP Iframe. (Edited: there is timing changes in focus event)

  • dom/events/test/test_bug409604.html

Focus moves to <tr> unexpected when the test sets its accesskey to "z" and synthesizes Z key.
Test got unexpected focus events after triggering access key, triggering access key seems fire two focus event.

  • dom/events/test/test_bug450876.html

Test expects focus staying on last focusable element (<a>) of the iframe after focus moves out of iframe by tab navigation. And with xorigin and fission enabled, the focus is reset after focus moves out of the iframe. But the expectation seems wrong, I got the same behavior as xorigin+fission case on other browsers, so it looks like it is a focus bug on non-fission case.

  • dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html

I could pass it locally, I will try to enable it.

Depends on: 1660752

Hi Edgar, do we know how to address the dom/events/test/test_bug409604.html and dom/events/test/test_bug450876.html failures?

Flags: needinfo?(echen)
Depends on: 1661415
Depends on: 1661682

(In reply to Edgar Chen [:edgar] from comment #13)

  • dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html

I could pass it locally, I will try to enable it.

Correction: there is an error on try, I actually got the same error but somehow it shows pass locally.
The failure is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1520785#c9.

(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #15)

Hi Edgar, do we know how to address the dom/events/test/test_bug409604.html and dom/events/test/test_bug450876.html failures?

Already know what the root cause is and filed bug accordingly,
dom/events/test/test_bug409604.html failure is a focus bug on fission.
dom/events/test/test_bug450876.html failure is related to an old bug and somehow is fixed on fission.
dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html failure depends on how test environment synthesizes the mouse event.

Flags: needinfo?(echen)
Depends on: 1662094
No longer depends on: 1662094

Moving this meta bug from Fission M6b to M6c since all the blocking bugs block M6c.

M6c means fixing the bug soon (in September, ideally) is important, but it doesn't block our Fission Nightly experiment (October 6).

Fission Milestone: M6b → M6c
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99964cee6df3
Enable editor/libeditor/tests/test_bug1151186.html on fission and cross-origin; r=masayuki
You need to log in before you can comment on or make changes to this bug.