Fix failing DOM:UI Events & Focus mochitests with cross-origin and Fission enabled
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P3)
Tracking
()
Fission Milestone | M6c |
People
(Reporter: neha, Assigned: edgar)
References
Details
Attachments
(4 files, 1 obsolete file)
These tests are marked as skipped/failed for cross-origin and Fission, and need to be fixed
dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
dom/events/test/test_bug238987.html
dom/events/test/test_bug450876.html
dom/events/test/test_bug741666.html
toolkit/content/tests/widgets/test_mousecapture_area.html
More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
|
||
Also, dom/events/test/pointerevents/test_trigger_popup_by_pointer_events.html is failing only when Fission is explicitly disabled so this test passing when Fission is enabled might be a false positive and needs to be looked into.
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)
Edgar, can you start to look into some of these?
Sure thing, take this bug.
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
bugherder |
Assignee | ||
Comment 8•4 years ago
|
||
Assignee | ||
Comment 9•4 years ago
|
||
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
bugherder |
Assignee | ||
Comment 12•4 years ago
|
||
Remaining tests,
- dom/events/test/test_bug238987.html
- dom/events/test/test_bug409604.html
- dom/events/test/test_bug450876.html
- dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
Updated•4 years ago
|
Assignee | ||
Comment 13•4 years ago
•
|
||
(In reply to Edgar Chen [:edgar] from comment #12)
- dom/events/test/test_bug238987.html
Test got unexpected focus
event for first tab navigation. Look like focus handling goes wrong on OOP Iframe. (Edited: there is timing changes in focus event)
- dom/events/test/test_bug409604.html
Focus moves to <tr> unexpected when the test sets its accesskey to "z" and synthesizes Z
key.
Test got unexpected focus events after triggering access key, triggering access key seems fire two
focus event.
- dom/events/test/test_bug450876.html
Test expects focus staying on last focusable element (<a>) of the iframe after focus moves out of iframe by tab navigation. And with xorigin and fission enabled, the focus is reset after focus moves out of the iframe. But the expectation seems wrong, I got the same behavior as xorigin+fission case on other browsers, so it looks like it is a focus bug on non-fission case.
- dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
I could pass it locally, I will try to enable it.
Assignee | ||
Comment 14•4 years ago
|
||
Comment 15•4 years ago
|
||
Hi Edgar, do we know how to address the dom/events/test/test_bug409604.html and dom/events/test/test_bug450876.html failures?
Assignee | ||
Comment 16•4 years ago
|
||
(In reply to Edgar Chen [:edgar] from comment #13)
- dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
I could pass it locally, I will try to enable it.
Correction: there is an error on try, I actually got the same error but somehow it shows pass locally.
The failure is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1520785#c9.
Assignee | ||
Comment 17•4 years ago
|
||
(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #15)
Hi Edgar, do we know how to address the dom/events/test/test_bug409604.html and dom/events/test/test_bug450876.html failures?
Already know what the root cause is and filed bug accordingly,
dom/events/test/test_bug409604.html failure is a focus bug on fission.
dom/events/test/test_bug450876.html failure is related to an old bug and somehow is fixed on fission.
dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html failure depends on how test environment synthesizes the mouse event.
Comment 18•4 years ago
|
||
Moving this meta bug from Fission M6b to M6c since all the blocking bugs block M6c.
M6c means fixing the bug soon (in September, ideally) is important, but it doesn't block our Fission Nightly experiment (October 6).
Assignee | ||
Comment 19•4 years ago
|
||
Assignee | ||
Comment 20•4 years ago
|
||
Comment 21•4 years ago
|
||
Comment 22•4 years ago
|
||
bugherder |
Reporter | ||
Comment 23•4 years ago
|
||
Edgar, thank you for fixing all the tests. We are now left with only 2:
dom/events/test/test_focus_blur_on_click_in_deep_cross_origin_iframe.html (no bug #)
dom/events/test/test_bug450876.html (bug 1661682)
Assignee | ||
Comment 24•4 years ago
|
||
(In reply to Neha Kochar [:neha] from comment #23)
dom/events/test/test_focus_blur_on_click_in_deep_cross_origin_iframe.html (no bug #)
Per https://searchfox.org/mozilla-central/rev/168c45a7acc44e9904cfd4eebcb9eb080e05699c/dom/events/test/mochitest.ini#247: Henri, since bug 1661227 is now closed, do you think if we could try to enable it back? If so, I could do it here.
Comment 25•4 years ago
|
||
(In reply to Edgar Chen [:edgar] from comment #24)
(In reply to Neha Kochar [:neha] from comment #23)
dom/events/test/test_focus_blur_on_click_in_deep_cross_origin_iframe.html (no bug #)
Per https://searchfox.org/mozilla-central/rev/168c45a7acc44e9904cfd4eebcb9eb080e05699c/dom/events/test/mochitest.ini#247: Henri, since bug 1661227 is now closed, do you think if we could try to enable it back? If so, I could do it here.
It might be OK to re-enable it already, but waiting for bug 1660805 should be more certain.
Assignee | ||
Comment 26•4 years ago
|
||
(In reply to Henri Sivonen (:hsivonen) from comment #25)
It might be OK to re-enable it already, but waiting for bug 1660805 should be more certain.
Ah, didn't aware it is enabled in the patch of bug 1660805. Thanks.
Assignee | ||
Comment 27•4 years ago
|
||
All dependencies are resolved. Close it!
Updated•4 years ago
|
Description
•