1653457 - Fix failing DOM:UI Events & Focus mochitests with cross-origin and Fission enabled

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Neha Kochar [:neha]]

These tests are marked as skipped/failed for cross-origin and Fission, and need to be fixed
dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
dom/events/test/test_bug238987.html
dom/events/test/test_bug450876.html
dom/events/test/test_bug741666.html
toolkit/content/tests/widgets/test_mousecapture_area.html

https://docs.google.com/spreadsheets/d/16G5AZhHWWow3rBgim4QBHzWXMIIJiky2SzXYgDMTTKY/edit#gid=1354562828&range=44:49

More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests

Comment 1

[Neha Kochar [:neha]]

Also, dom/events/test/pointerevents/test_trigger_popup_by_pointer_events.html is failing only when Fission is explicitly disabled so this test passing when Fission is enabled might be a false positive and needs to be looked into.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Edgar, can you start to look into some of these?

Comment 3

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)

Edgar, can you start to look into some of these?

Sure thing, take this bug.

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1653457 - Enable dom/events/test/test_bug238987.html on Fission;

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1653457 - Enable dom/events/test/test_bug741666.html on fission and cross-origin;

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/343e0c4bd424
Enable dom/events/test/test_bug741666.html on fission and cross-origin; r=smaug DONTBUILD

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/343e0c4bd424

Comment 8

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1653457 - Enable dom/events/test/pointerevents/test_touch_action.html on fission and cross-origin;

Comment 9

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1653457 - Enable dom/events/test/test_bug1581192.html on fission and cross-origin;

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c945ea0c61d
Enable dom/events/test/pointerevents/test_touch_action.html on fission and cross-origin; r=smaug DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/cb8d53bf489f
Enable dom/events/test/test_bug1581192.html on fission and cross-origin; r=smaug DONTBUILD

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3c945ea0c61d
https://hg.mozilla.org/mozilla-central/rev/cb8d53bf489f

Comment 12

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Remaining tests,

• dom/events/test/test_bug238987.html
• dom/events/test/test_bug409604.html
• dom/events/test/test_bug450876.html
• dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html

Comment 13

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Edgar Chen [:edgar] from comment #12)

• dom/events/test/test_bug238987.html

Test got unexpected focus event for first tab navigation. Look like focus handling goes wrong on OOP Iframe. (Edited: there is timing changes in focus event)

• dom/events/test/test_bug409604.html

Focus moves to <tr> unexpected when the test sets its accesskey to "z" and synthesizes Z key.
Test got unexpected focus events after triggering access key, triggering access key seems fire two focus event.

• dom/events/test/test_bug450876.html

Test expects focus staying on last focusable element (<a>) of the iframe after focus moves out of iframe by tab navigation. And with xorigin and fission enabled, the focus is reset after focus moves out of the iframe. But the expectation seems wrong, I got the same behavior as xorigin+fission case on other browsers, so it looks like it is a focus bug on non-fission case.

• dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html

I could pass it locally, I will try to enable it.

Comment 14

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d15e19aa12a276026f6f4c12a9f6c9f8d14d7320

Comment 15

[Jens Stutte [:jstutte]]

Hi Edgar, do we know how to address the dom/events/test/test_bug409604.html and dom/events/test/test_bug450876.html failures?

Comment 16

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Edgar Chen [:edgar] from comment #13)

• dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html

I could pass it locally, I will try to enable it.

Correction: there is an error on try, I actually got the same error but somehow it shows pass locally.
The failure is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1520785#c9.

Comment 17

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #15)

Hi Edgar, do we know how to address the dom/events/test/test_bug409604.html and dom/events/test/test_bug450876.html failures?

Already know what the root cause is and filed bug accordingly,
dom/events/test/test_bug409604.html failure is a focus bug on fission.
dom/events/test/test_bug450876.html failure is related to an old bug and somehow is fixed on fission.
dom/events/test/pointerevents/test_pointerevent_setpointercapture_inactive_button_mouse-manual.html failure depends on how test environment synthesizes the mouse event.

Comment 18

[Chris Peterson [:cpeterson]]

Moving this meta bug from Fission M6b to M6c since all the blocking bugs block M6c.

M6c means fixing the bug soon (in September, ideally) is important, but it doesn't block our Fission Nightly experiment (October 6).

Comment 19

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1653457 - Enable editor/libeditor/tests/test_bug1151186.html on fission and cross-origin;

Comment 20

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d1d52c39dbbc2b06df799b7a885fbc37d242ee4

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99964cee6df3
Enable editor/libeditor/tests/test_bug1151186.html on fission and cross-origin; r=masayuki

Comment 22

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/99964cee6df3

Comment 23

[Neha Kochar [:neha]]

Edgar, thank you for fixing all the tests. We are now left with only 2:
dom/events/test/test_focus_blur_on_click_in_deep_cross_origin_iframe.html (no bug #)
dom/events/test/test_bug450876.html (bug 1661682)

Comment 24

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Neha Kochar [:neha] from comment #23)

dom/events/test/test_focus_blur_on_click_in_deep_cross_origin_iframe.html (no bug #)

Per https://searchfox.org/mozilla-central/rev/168c45a7acc44e9904cfd4eebcb9eb080e05699c/dom/events/test/mochitest.ini#247: Henri, since bug 1661227 is now closed, do you think if we could try to enable it back? If so, I could do it here.

Comment 25

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

(In reply to Edgar Chen [:edgar] from comment #24)

(In reply to Neha Kochar [:neha] from comment #23)

dom/events/test/test_focus_blur_on_click_in_deep_cross_origin_iframe.html (no bug #)

Per https://searchfox.org/mozilla-central/rev/168c45a7acc44e9904cfd4eebcb9eb080e05699c/dom/events/test/mochitest.ini#247: Henri, since bug 1661227 is now closed, do you think if we could try to enable it back? If so, I could do it here.

It might be OK to re-enable it already, but waiting for bug 1660805 should be more certain.

Comment 26

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Henri Sivonen (:hsivonen) from comment #25)

It might be OK to re-enable it already, but waiting for bug 1660805 should be more certain.

Ah, didn't aware it is enabled in the patch of bug 1660805. Thanks.

Comment 27

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

All dependencies are resolved. Close it!