Closed Bug 1653628 Opened 5 years ago Closed 5 years ago

Multiple drop down arrow in the preference menulist in remote content notification

Categories

(Thunderbird :: Mail Window Front End, defect, P1)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect

Tracking

(thunderbird_esr78 fixed, thunderbird78 wontfix, thunderbird79 fixed, thunderbird80 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 80.0
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed
thunderbird78 --- wontfix
thunderbird79 --- fixed
thunderbird80 --- fixed

People

(Reporter: khushil324, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Screenshot 2020-07-17 at 10.16.53 PM.png
10.19 KB, image/png
Details
1653628-notification-menulist-button.patch
1013 bytes, patch
aleca
: review+
Details | Diff | Splinter Review
1653628-notification-menulist-button-beta-ESR.patch
984 bytes, patch
wsmwk
: approval-comm-beta+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review
No description provided.

A small issues. Do you guys see this on Linux and Windows?

Yup, I see this too on Linux as well.

I was wrong, it's Bug 1650789 regressing it - and it landed on TB 78.0.1.

Severity: -- → S1
status-thunderbird78: --- → affected
status-thunderbird79: --- → affected
status-thunderbird80: --- → affected
Priority: -- → P1

Ouch, I missed that as well.

Fix

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9164411 - Flags: review?(alessandro)

Fix for beta and ESR.
I'm setting the flags, when the c-c patch gets r+.

Comment on attachment 9164411 [details] [diff] [review] 1653628-notification-menulist-button.patch Review of attachment 9164411 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this solves the issue. I don't remember what we decided, but is correct the type of styling we get for that button, right? Non native but grey with dark grey border? Themeable? Just double checking here because my memory is terrible.
Attachment #9164411 - Flags: review?(alessandro) → review+

Yes, themeable to work with the draft notification button.

Comment on attachment 9164412 [details] [diff] [review] 1653628-notification-menulist-button-beta-ESR.patch [Approval Request Comment] Regression caused by (bug #): Bug 1650789 User impact if declined: double dropdowns on Mac and Linux Testing completed (on c-c, etc.): soon on c-c Risk to taking this patch (and alternatives if risky): low
Attachment #9164412 - Flags: approval-comm-esr78?
Attachment #9164412 - Flags: approval-comm-beta?
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 80.0
Comment on attachment 9164412 [details] [diff] [review] 1653628-notification-menulist-button-beta-ESR.patch Approved for beta (if we need to respin 79.0b2 for something else then we can take this)
Attachment #9164412 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9164412 [details] [diff] [review] 1653628-notification-menulist-button-beta-ESR.patch Approved for respin of 78.0.1
Attachment #9164412 - Flags: approval-comm-esr78? → approval-comm-esr78+

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/e6d286af6267
Remove the native menulist-button appearance on notifications. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: