1650789 - Some white areas on Address book contact preview

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Especially on Mac the contact preview is white with the dark theme. Also on the other platforms the "Get Map" buttons aren't styled for the dark theme.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1650789-AB-styles.patch

I moved more code to the shared files and make the appearance more consistent between the platforms.
Moving some code for the buttons to messenger.css made it possible to remove some code from the notification.css and made it available for the AB too.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9161607 [details] [diff] [review]
1650789-AB-styles.patch

Review of attachment 9161607 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9161607 [details] [diff] [review]
1650789-AB-styles.patch

[Approval Request Comment]
User impact if declined: on Mac no good experience in the AB with dark theme
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c08a3ac61c3f
Improve styles for dark Address book. r=aleca DONTBUILD

Comment 5

[Geoff Lankow (:darktrojan)]

Thunderbird 79.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/0679cb00dccb

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9161607 [details] [diff] [review]
1650789-AB-styles.patch

Approved for esr78.  let's again make sure this gets targeted for smoketest

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.0.1:
https://hg.mozilla.org/releases/comm-esr78/rev/b6f586025149

Comment 8

[Wayne Mery (:wsmwk)]

Walt, how does this look for you on Windows?

For Mac, I am stuck on 79.0b2, where I'm not even able to enable dark mode. I get
SyntaxError: redeclaration of const THUNDERBIRD_THEME_PREVIEWS
aboutAddonsExtra.js:1:1
08:27:54.301
Uncaught SyntaxError: redeclaration of const THUNDERBIRD_THEME_PREVIEWS
<anonymous> chrome://messenger/content/aboutAddonsExtra.js:1
observe chrome://messenger/content/specialTabs.js:1748
aboutAddonsExtra.js:1:1
08:27:59.435 Uncaught (in promise) TypeError: addon.userPermissions is null
shouldShowPermissionsPrompt chrome://mozapps/content/extensions/aboutaddonsCommon.js:156
handleEvent chrome://mozapps/content/extensions/aboutaddons.js:2814
aboutaddonsCommon.js:156:36

Comment 9

[WaltS48 [:walts48]]

Looks okay to me on Windows 10 and Ubuntu Linux.

Comment 10

[Geoff Lankow (:darktrojan)]

I've not seen that first error before, but it may be related to the other one, which is bug 1647931.