NS_ERROR_FAILURE: The root address book no longer exists AddrBookManager.jsm:193
Categories
(Thunderbird :: Address Book, defect)
Tracking
(thunderbird_esr68 unaffected, thunderbird_esr78 fixed, thunderbird74 unaffected, thunderbird75 wontfix, thunderbird76 wontfix, thunderbird77 wontfix, thunderbird78 wontfix, thunderbird79 affected, thunderbird80 fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr68 | --- | unaffected |
| thunderbird_esr78 | --- | fixed |
| thunderbird74 | --- | unaffected |
| thunderbird75 | --- | wontfix |
| thunderbird76 | --- | wontfix |
| thunderbird77 | --- | wontfix |
| thunderbird78 | --- | wontfix |
| thunderbird79 | --- | affected |
| thunderbird80 | --- | fixed |
People
(Reporter: walts48, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression, Whiteboard: smoketestbeta)
Attachments
(3 files)
|
31.41 KB,
image/png
|
Details | |
|
3.46 KB,
patch
|
khushil324
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
|
11.40 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
Advanced Address Book Search.png
In testing 79.0b3 release candidate (build1) I noticed the selectors and search field are missing from the Advanced Search dialogue window.
Open the Address Book.
Select Edit > Search Addresses
The default "Display Name" and "Contains" drop downs are missing and so is the empty field.
|
||
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=306ac4b77c679440f825d487a9147544591db953&tochange=a04956310d2fe4df06c9ba41cb7bb239a09341d4
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5bfe22b4bd0d64b9d105b66b3ed0fcee10d70e93&tochange=5bfe22b4bd0d64b9d105b66b3ed0fcee10d70e93
|
Assignee | |
Comment 2•4 years ago
|
||
I didn't know this dialog existed (well I did, but obviously it's not a priority to my memory cells). It's broken in at least two ways, which I'm fixing here, and it's in a stupid place in the code, which I'll fix in a separate patch.
|
|
Assignee | |
Comment 3•4 years ago
|
||
Moves the dialog from mail/base/content to mail/components/addrbook/content, which is where address book dialogs should live.
|
||
Comment 4•4 years ago
|
||
Comment on attachment 9166195 [details] [diff] [review] 1655332-move-absearch-1.diff Review of attachment 9166195 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=da06f42dd926874a50cfbcf8f2abbb23bc557e41
|
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9166194 [details] [diff] [review] 1655332-fix-absearch-1.diff Review of attachment 9166194 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil
|
|
||
Comment 6•4 years ago
|
||
I have sent it for a try-run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=da06f42dd926874a50cfbcf8f2abbb23bc557e41
|
|
Assignee | |
Comment 7•4 years ago
|
||
The try run has an address book failure, but it already existed.
|
|
Assignee | |
Comment 8•4 years ago
|
||
Comment on attachment 9166194 [details] [diff] [review] 1655332-fix-absearch-1.diff Missed the boat.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/6e0293aa4d1b
Repair broken address book search dialog. r=khushil
https://hg.mozilla.org/comm-central/rev/82dd45031298
Move address book search dialog to a more logical place. r=khushil
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Comment 10•4 years ago
|
||
Comment on attachment 9166194 [details] [diff] [review] 1655332-fix-absearch-1.diff Approved for beta
|
||
Comment 11•4 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•4 years ago
|
|
|
||
Comment 12•4 years ago
|
||
Comment on attachment 9166194 [details] [diff] [review] 1655332-fix-absearch-1.diff [Triage Comment] Approved for esr78
|
|
||
Comment 13•4 years ago
|
||
| bugherder uplift | ||
Description
•