Closed Bug 1655332 Opened 4 years ago Closed 4 years ago

NS_ERROR_FAILURE: The root address book no longer exists AddrBookManager.jsm:193

Categories

(Thunderbird :: Address Book, defect)

Desktop
All
defect

Tracking

(thunderbird_esr68 unaffected, thunderbird_esr78 fixed, thunderbird74 unaffected, thunderbird75 wontfix, thunderbird76 wontfix, thunderbird77 wontfix, thunderbird78 wontfix, thunderbird79 affected, thunderbird80 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr68 --- unaffected
thunderbird_esr78 --- fixed
thunderbird74 --- unaffected
thunderbird75 --- wontfix
thunderbird76 --- wontfix
thunderbird77 --- wontfix
thunderbird78 --- wontfix
thunderbird79 --- affected
thunderbird80 --- fixed

People

(Reporter: walts48, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression, Whiteboard: smoketestbeta)

Attachments

(3 files)

In testing 79.0b3 release candidate (build1) I noticed the selectors and search field are missing from the Advanced Search dialogue window.

Open the Address Book.
Select Edit > Search Addresses
The default "Display Name" and "Contains" drop downs are missing and so is the empty field.

Flags: needinfo?(geoff)

I didn't know this dialog existed (well I did, but obviously it's not a priority to my memory cells). It's broken in at least two ways, which I'm fixing here, and it's in a stupid place in the code, which I'll fix in a separate patch.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attachment #9166194 - Flags: review?(khushil324)
Attachment #9166194 - Flags: approval-comm-esr78?

Moves the dialog from mail/base/content to mail/components/addrbook/content, which is where address book dialogs should live.

Attachment #9166195 - Flags: review?(khushil324)
Comment on attachment 9166195 [details] [diff] [review] 1655332-move-absearch-1.diff Review of attachment 9166195 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=da06f42dd926874a50cfbcf8f2abbb23bc557e41
Attachment #9166195 - Flags: review?(khushil324) → review+
Comment on attachment 9166194 [details] [diff] [review] 1655332-fix-absearch-1.diff Review of attachment 9166194 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil
Attachment #9166194 - Flags: review?(khushil324) → review+

The try run has an address book failure, but it already existed.

Comment on attachment 9166194 [details] [diff] [review] 1655332-fix-absearch-1.diff Missed the boat.
Attachment #9166194 - Flags: approval-comm-beta?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/6e0293aa4d1b
Repair broken address book search dialog. r=khushil
https://hg.mozilla.org/comm-central/rev/82dd45031298
Move address book search dialog to a more logical place. r=khushil

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Comment on attachment 9166194 [details] [diff] [review] 1655332-fix-absearch-1.diff Approved for beta
Attachment #9166194 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9166194 [details] [diff] [review] 1655332-fix-absearch-1.diff [Triage Comment] Approved for esr78
Attachment #9166194 - Flags: approval-comm-esr78? → approval-comm-esr78+
See Also: → 1668147
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: