1655381 - Firefox Accounts toolbar item thinks I'm signed out in new windows

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[u608768]

STR

1. Ensure that you have the "Firefox Account" item in your toolbar and that it shows that you're signed in (the menu should show your email, an "Account Settings" button, etc).
2. Close Firefox and reopen it.
3. Confirm that the toolbar item still shows that you're signed in.
4. Open a new window (ctrl+n/file menu/however).
5. You should notice that the toolbar item no longer shows that you're signed in.

Actual results

The toolbar item shows that I'm not signed in. It shows the generic avatar thing and a "Sign in to Firefox" button.

Expected results

The toolbar item should show that I'm still signed in.

mozregression points to bug 1653846 (I ran it a few times).

Comment 1

[u608768]

(In reply to :kashav from comment #0)

Expected results

The toolbar item should show that I'm still signed in.

I'm still signed in and syncing according to about:preferences#sync.

Comment 2

[Emma Malysz]

Attachment: Bug 1655381, ensure we use the correct window's view cache template to display correct firefox account info

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93cf30f53b76
ensure we use the correct window's view cache template to display correct firefox account info r=sfoster

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/93cf30f53b76

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1648637

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emalysz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emma Malysz]

Comment on attachment 9166383 [details]
Bug 1655381, ensure we use the correct window's view cache template to display correct firefox account info

Beta/Release Uplift Approval Request

• User impact if declined: Users signed into fxa with multiple windows open will not be signed in on all.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: A bug was filed to create a test case (Bug 1655776) that would have caught this error.

1. Open Firefox
2. Sign into fxa
3. Notice toolbar icon indicates you are signed in
4. Open new window
5. See that you are signed in on that window as well.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A simple frontend only change with no other alternative.
• String changes made/needed: None

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9166383 [details]
Bug 1655381, ensure we use the correct window's view cache template to display correct firefox account info

regression fix, approved for 80.0b3

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9bc42dee3c8f

Comment 11

[Peter Magyari (Desktop QA)]

Reproduced the issue on Firefox 81.0a1 (20200727203201) and Firefox 80.0b2 (20200730152159)
Verified fixed on Firefox 81.0a1 (20200803213927) and Firefox 80.0b3 (20200803045446)