1655964 - Move nsIDocShell::allowJavascript to BrowsingContext

Status: RESOLVED DUPLICATE of bug 1646560

(Core :: DOM: Navigation, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

+++ This bug was initially created as a clone of Bug #1655959 +++

This attribute is used by DevTools and is expected to be also applied to remoted Fission iframe.
By setting this attribute on nsIDocShell, we don't ensure applying it to remote iframe, which spawn another nsIDocShell in their distinct process.
The typical way to fix that is to move such attribute up to BrowsingContext class.
You can take example on bug 1593708, which moved inRDMPanel from PresShell up to BrowsingContext. Or bug 1620966, which moved watchedByDevTools from DocShell up to BrowsingContext.

I imagine that it may also fix non-devtools usecase if this attribute is toggled outside of DevTools.
See bug 1591120 for extensive context.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).

Comment 2

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Comment 3

[Chris Peterson [:cpeterson]]

Moving old "dt-fission-m2-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 4

[Neha Kochar [:neha]]

Keeping this in Fission MVP. dt-fission-future is a backlog of all devtools untriaged fission bugs.

Comment 5

[Chris Peterson [:cpeterson]]

dt-fission-future bugs don't need to block Fission MVP, so I'm moving them from Fission Milestone MVP to Future.

Comment 6

[Neha Kochar [:neha]]

Sending this to dt triage to ensure this gets re-reviewed for appropriate milestone.

Comment 7

[Chris Peterson [:cpeterson]]

kmag fixed this bug 1646560.