1656360 - Mochitest failures due to AccountWizard opening as modal.

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P1)

Description

[Alessandro Castellani [:aleca]]

TEST-UNEXPECTED-FAIL | comm/mail/test/browser/account/browser_mailAccountSetupWizard.js | Uncaught exception - at resource://testing-common/mozmill/utils.jsm:127 - TimeoutError: Timeout waiting for modal dialog to open.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311549070&repo=comm-central&lineNumber=1880

TEST-UNEXPECTED-TIMEOUT | comm/mail/test/browser/newmailaccount/browser_newmailaccount.js | application timed out after 370 seconds with no output
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311549102&repo=comm-central&lineNumber=3181

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1656360-tests.diff

We can't currently use the emailWizard as modal due to the way it was originally designed.
We have plans to drop this dialog entirely in the future anyway, so better revert back the change and avoid multiple issues.

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9167160 [details] [diff] [review]
1656360-tests.diff

I'll ship this now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e4234b47d041
Fix TimeoutError test failures when interacting with the emailWizard. r=darktrojan

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9167160 [details] [diff] [review]
1656360-tests.diff

[Approval Request Comment]
Regression caused by (bug #): bug 1655289
User impact if declined: broken tests and broken manual config during account setup
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9167160 [details] [diff] [review]
1656360-tests.diff

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/352435e3a616

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9167160 [details] [diff] [review]
1656360-tests.diff

[Triage Comment]
Approved for esr78

Comment 8

[Geoff Lankow (:darktrojan)]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/27ae74a85bdd