1656799 - Rewrite `HTMLEditor::HandleDeleteNonCollapsedSelection()` as not using `Selection`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

After fixing bug 1656430, we can make it free from Selection.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656799 - part 1: Make `HTMLEditor::HandleDeleteNonCollapsedSelection()` store selection ranges with `AutoRangeArray` first r=m_kato!

Depends on D85686

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656799 - part 2: Create range tracker r=m_kato!

There is only AutoTrackDOMPoint, but
HTMLEditor::HandleDeleteNonCollapsedSelection() requires to tack pairs of
DOM points, i.e., requires to track ranges. For making the code simpler,
we should have range tracker too.

Depends on D85845

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656799 - part 3: Make `WhiteSpaceVisibilityKeeper::PrepareToDeleteRange()` not track `EditorDOMPoint`s r=m_kato!

It may be faster to use AutoTrackDOMRange directly. Therefore, current
WhiteSpaceVisibilityKeeper::PrepareToDeleteRange() should be renamed to
WhiteSpaceVisibilityKeeper::PrepareToDeleteRangeAndTrackPoints() and
we should make HTMLEditor::HandleDeleteNonCollapsedSelection() track
the range by itself.

Depends on D85846

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656799 - part 4: Make `HTMLEditor::HandleDeleteNonCollapsedSelection()` take ranges to delete instead of retrieving it via `Selection` r=m_kato!

Depends on D85847

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656799 - part 5: Make `HTMLEditor::GetRangeExtendedToIncludeInvisibleNodes()` directly extend given range r=m_kato!

Creation cost of nsRange is expensive, and it's only user,
HTMLEditor::HandleDeleteNonCollapsedRanges() wants to extend the range.
Therefore, we can make it directly extend the given range.

Depends on D85848

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27409fc97733
part 1: Make `HTMLEditor::HandleDeleteNonCollapsedSelection()` store selection ranges with `AutoRangeArray` first r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cd8960cc9561
part 2: Create range tracker r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5f6940372132
part 3: Make `WhiteSpaceVisibilityKeeper::PrepareToDeleteRange()` not track `EditorDOMPoint`s r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ea2f2ca8c778
part 4: Make `HTMLEditor::HandleDeleteNonCollapsedSelection()` take ranges to delete instead of retrieving it via `Selection` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5f6fd01e29a2
part 5: Make `HTMLEditor::GetRangeExtendedToIncludeInvisibleNodes()` directly extend given range r=m_kato

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/27409fc97733
https://hg.mozilla.org/mozilla-central/rev/cd8960cc9561
https://hg.mozilla.org/mozilla-central/rev/5f6940372132
https://hg.mozilla.org/mozilla-central/rev/ea2f2ca8c778
https://hg.mozilla.org/mozilla-central/rev/5f6fd01e29a2