1656980 - Crash in [@ mozilla::net::CookiePersistentStorage::EnsureReadComplete]

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[[:philipp]]

+++ This bug was initially created as a clone of Bug #1650211 +++

the crash signature from bug 1650211 (which received a fix in 79) seems to be reappearing now at the start of the 80.0b cycle, so i'm filing this as a cloned bug.

sample crash report: bp-611134bf-6bfc-43b3-ab94-4514d0200731.

Top 8 frames of crashing thread:

0 xul.dll mozilla::net::CookiePersistentStorage::EnsureReadComplete netwerk/cookie/CookiePersistentStorage.cpp:1687
1 xul.dll mozilla::net::CookieService::GetCookiesSince netwerk/cookie/CookieService.cpp:2240
2 xul.dll XPTC__InvokebyIndex 
3  @0x5ab8f0f2b8e38 
4 xul.dll nsXPTType::IsDependent const xpcom/reflect/xptinfo/xptinfo.h:263
5 xul.dll static XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1140
6 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:946
7  @0x88bd793ed9 

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1656980 - CookieService::GetCookiesSince needs to check the CookieService initialization state, r?mayhemer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09921685a632
CookieService::GetCookiesSince needs to check the CookieService initialization state, r=mayhemer

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/09921685a632

Comment 4

[Julien Cristau [:jcristau] (back August 18)]

Care to request beta uplift, Andrea?

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 9167819 [details]
Bug 1656980 - CookieService::GetCookiesSince needs to check the CookieService initialization state, r?mayhemer

Beta/Release Uplift Approval Request

• User impact if declined: A crash can occur in CookieService
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): GetCookiesSince() is the only getter method in CookieService without initialization check. The fix is low risk.
• String changes made/needed: none

Comment 6

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9167819 [details]
Bug 1656980 - CookieService::GetCookiesSince needs to check the CookieService initialization state, r?mayhemer

crash fix, approved for 80.0b5

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/335050d5d257