Scrollbars and radio buttons (and maybe more) are smaller with high DPI, when native theme disabled
Categories
(Core :: Widget, defect, P2)
Tracking
()
People
(Reporter: itiel_yn8, Unassigned)
References
Details
Attachments
(5 files)
Regular scrollbar
STR:
- On Windows, set the DPI to something higher than 100% (the attached screenshots are with DPI = 150%)
- Toggle
widget.disable-native-theme-for-contenton - Observe scrollbars and radio buttons
AR:
Smaller than they should be (I assume they are displayed as if DPI = 100%).
ER:
Same size as with native theme enabled.
|
||
Comment 5•4 years ago
|
||
This should definitely have been DPI aware, and it looks like it's working properly on macOS. Will look into it.
|
||
Comment 6•4 years ago
|
||
I think we may be truncating the 150% to 100% somewhere because GetDPIRatio usually only does integers.
|
|
||
Comment 7•4 years ago
|
||
(In reply to Itiel from comment #0)
STR:
- On Windows, set the DPI to something higher than 100% (the attached screenshots are with DPI = 150%)
Just to double-check: Where are you setting the DPI? And is it safe to assume that a value of 150% is a reasonable thing to see on Windows? Or is this an edge-case?
(In reply to Stephen A Pohl [:spohl] from comment #7)
(In reply to Itiel from comment #0)
STR:
- On Windows, set the DPI to something higher than 100% (the attached screenshots are with DPI = 150%)
Just to double-check: Where are you setting the DPI?
From Windows' settings.
https://www.youtube.com/watch?v=TL4ePJNZeds
And is it safe to assume that a value of 150% is a reasonable thing to see on Windows? Or is this an edge-case?
AFAIK 125-150% is very common. I don't consider it an edge-case at all.
|
||
Comment 9•4 years ago
|
||
AFAIK 125-150% is very common. I don't consider it an edge-case at all.
FWIW, on my Windows 10 laptop, the default display scale is 250% and Windows' Display settings say: Make everything bigger > Change the size of apps and text on the main display > 250% (Recommended).
|
||
Comment 10•4 years ago
|
||
The severity field is not set for this bug.
:jimm, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Comment 11•4 years ago
|
||
Tracking non-native theming bugs for Fission Beta milestone (M7).
|
|
||
Comment 12•4 years ago
|
||
Could you check and see if this is fixed in this try build? Thank you!
|
Reporter | |
Comment 13•4 years ago
|
||
(In reply to Stephen A Pohl [:spohl] from comment #12)
Could you check and see if this is fixed in this try build? Thank you!
Do you have the ZIP link, instead? I'd like to avoid installing stuff, when possible.
(I can also moz-phab patch to the relevant patch, if needed. Is it https://phabricator.services.mozilla.com/D102094 ?)
|
|
||
Comment 14•4 years ago
|
||
Oh yes, here it is: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Zy9lK9zaQHqFUq7xSbybGw/runs/0/artifacts/public/build/target.zip
Patch would indeed be https://phabricator.services.mozilla.com/D102094.
Thank you!
|
|
Reporter | |
Comment 15•4 years ago
|
||
(In reply to Stephen A Pohl [:spohl] from comment #14)
Oh yes, here it is: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Zy9lK9zaQHqFUq7xSbybGw/runs/0/artifacts/public/build/target.zip
Patch would indeed be https://phabricator.services.mozilla.com/D102094.
Thank you!
Thanks!
The scrollbar width is back to normal(ish), but:
- It's wider than the current one by 1-3px. Not a deal breaker and is fine as-is, just wanted to let you know
- The scroll arrows are still tiny
btw the radio buttons (see comment 4) are fine even on Nightly.
|
|
Reporter | |
Comment 16•4 years ago
|
||
|
|
||
Comment 17•4 years ago
|
||
(In reply to Itiel from comment #15)
Thanks!
The scrollbar width is back to normal(ish), but:
- It's wider than the current one by 1-3px. Not a deal breaker and is fine as-is, just wanted to let you know
This is when display scale is applied, correct? It is possible that there may be a rounding issue here.
- The scroll arrows are still tiny
Yes, I intend to address this in a separate patch in bug 1615038.
btw the radio buttons (see comment 4) are fine even on Nightly.
Thanks for confirming!
|
|
Reporter | |
Comment 18•4 years ago
|
||
(In reply to Stephen A Pohl [:spohl] from comment #17)
(In reply to Itiel from comment #15)
- It's wider than the current one by 1-3px. Not a deal breaker and is fine as-is, just wanted to let you know
This is when display scale is applied, correct? It is possible that there may be a rounding issue here.
Yes, on 150%.
|
|
||
Comment 19•4 years ago
|
||
This is (mostly) addressed in bug 1615038. Let's get narrower and dedicated bugs on file if we still encounter this in some scenarios.
Description
•