Closed Bug 1657191 Opened 1 year ago Closed 6 months ago

Scrollbars and radio buttons (and maybe more) are smaller with high DPI, when native theme disabled

Categories

(Core :: Widget, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Fission Milestone M7
Tracking Status
firefox81 --- affected

People

(Reporter: itiel_yn8, Unassigned)

References

Details

Attachments

(5 files)

STR:

  1. On Windows, set the DPI to something higher than 100% (the attached screenshots are with DPI = 150%)
  2. Toggle widget.disable-native-theme-for-content on
  3. Observe scrollbars and radio buttons

AR:
Smaller than they should be (I assume they are displayed as if DPI = 100%).

ER:
Same size as with native theme enabled.

Attached image Regular scrollbar
Attached image Tiny scrollbar
Attached image Regular radio button
Attached image Tiny radio button

This should definitely have been DPI aware, and it looks like it's working properly on macOS. Will look into it.

Blocks: 1615105

I think we may be truncating the 150% to 100% somewhere because GetDPIRatio usually only does integers.

(In reply to Itiel from comment #0)

STR:

  1. On Windows, set the DPI to something higher than 100% (the attached screenshots are with DPI = 150%)

Just to double-check: Where are you setting the DPI? And is it safe to assume that a value of 150% is a reasonable thing to see on Windows? Or is this an edge-case?

Flags: needinfo?(itiel_yn8)

(In reply to Stephen A Pohl [:spohl] from comment #7)

(In reply to Itiel from comment #0)

STR:

  1. On Windows, set the DPI to something higher than 100% (the attached screenshots are with DPI = 150%)

Just to double-check: Where are you setting the DPI?

From Windows' settings.
https://www.youtube.com/watch?v=TL4ePJNZeds

And is it safe to assume that a value of 150% is a reasonable thing to see on Windows? Or is this an edge-case?

AFAIK 125-150% is very common. I don't consider it an edge-case at all.

Flags: needinfo?(itiel_yn8)

AFAIK 125-150% is very common. I don't consider it an edge-case at all.

FWIW, on my Windows 10 laptop, the default display scale is 250% and Windows' Display settings say: Make everything bigger > Change the size of apps and text on the main display > 250% (Recommended).

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jmathies)
Severity: -- → S2
Priority: -- → P2
Flags: needinfo?(jmathies)
See Also: → 1663514

Tracking non-native theming bugs for Fission Beta milestone (M7).

Fission Milestone: --- → M7
Flags: needinfo?(itiel_yn8)

(In reply to Stephen A Pohl [:spohl] from comment #12)

Could you check and see if this is fixed in this try build? Thank you!

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Zy9lK9zaQHqFUq7xSbybGw/runs/0/artifacts/public/build/setup.exe

Do you have the ZIP link, instead? I'd like to avoid installing stuff, when possible.
(I can also moz-phab patch to the relevant patch, if needed. Is it https://phabricator.services.mozilla.com/D102094 ?)

Flags: needinfo?(itiel_yn8) → needinfo?(spohl.mozilla.bugs)

(In reply to Stephen A Pohl [:spohl] from comment #14)

Oh yes, here it is: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Zy9lK9zaQHqFUq7xSbybGw/runs/0/artifacts/public/build/target.zip

Patch would indeed be https://phabricator.services.mozilla.com/D102094.

Thank you!

Thanks!
The scrollbar width is back to normal(ish), but:

  1. It's wider than the current one by 1-3px. Not a deal breaker and is fine as-is, just wanted to let you know
  2. The scroll arrows are still tiny

btw the radio buttons (see comment 4) are fine even on Nightly.

Flags: needinfo?(itiel_yn8) → needinfo?(spohl.mozilla.bugs)
Attachment #9197631 - Attachment mime type: text/plain → image/png

(In reply to Itiel from comment #15)

Thanks!
The scrollbar width is back to normal(ish), but:

  1. It's wider than the current one by 1-3px. Not a deal breaker and is fine as-is, just wanted to let you know

This is when display scale is applied, correct? It is possible that there may be a rounding issue here.

  1. The scroll arrows are still tiny

Yes, I intend to address this in a separate patch in bug 1615038.

btw the radio buttons (see comment 4) are fine even on Nightly.

Thanks for confirming!

Flags: needinfo?(spohl.mozilla.bugs)

(In reply to Stephen A Pohl [:spohl] from comment #17)

(In reply to Itiel from comment #15)

  1. It's wider than the current one by 1-3px. Not a deal breaker and is fine as-is, just wanted to let you know

This is when display scale is applied, correct? It is possible that there may be a rounding issue here.

Yes, on 150%.

This is (mostly) addressed in bug 1615038. Let's get narrower and dedicated bugs on file if we still encounter this in some scenarios.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.