1657443 - sw-wr: YouTube video shows multiple frames and other image clipping problems

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: YouTube_screenshot.jpg

Steps to reproduce

1. Set gfx.webrender.software pref = true.
2. Load https://www.youtube.com/watch?v=Y9KyBdPeKHg
3. Play the video.

Actual result

The video shows multiple small frames along the top of the video and then other image clipping problems. See the attached screenshot.

If I reset gfx.webrender.software to false, the problem appears to go away.

I bisected this regression to the following pushlog, which includes to three different WebRender bugs. I assume this regression is caused by bug 1653166 because I'm on Windows and the other two bugs mention macOS.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ed6ec0c8220321b13c108ffaa7ab6cfc8d7698f&tochange=4558b3cfd6fe49647780a0ec86dfa97f0dd3adcb

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: My about:support

Comment 2

[Dzmitry Malyshau [:kvark]]

Marking as S3 since this isn't enabled yet

Comment 3

[Matt Woodrow (:mattwoodrow)]

Is this fixed now? I landed some changes to support scaling properly for SWWR in bug 1657771.

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: YouTube_screenshot_2020-08-26.jpg.png

(In reply to Matt Woodrow (:mattwoodrow) from comment #3)

Is this fixed now? I landed some changes to support scaling properly for SWWR in bug 1657771.

No. The video is still broken with SWWR, but in a different way. See this new screenshot.

Comment 5

[Chris Peterson [:cpeterson]]

Closing as WORKSFORME because I can no longer reproduce this bug.

Comment 6

[Chris Peterson [:cpeterson]]

Like bug 1659369, I suspect this bug was fixed by SwCompositor bug 1622966.

Comment 7

[Markus Stange [:mstange]]

This bug might still be present in the slow path which kicks in when WR cannot layerize the video.