Closed Bug 1657455 Opened 4 years ago Closed 4 years ago

Give EnumSet an assignment operator

Categories

(Core :: MFBT, defect)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: away, Assigned: away)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.

Newer clangs complain that we explicitly defined a copy constructor but not a copy assignment.

Weren't these -Wdeprecated-copy warnings suppressed in bug 1515356? Looks like the warnings are still reported, but downgraded from errors to warnings.

https://searchfox.org/mozilla-central/rev/26b13464c2beb26e0d864d561c30e817a85c348a/build/moz.configure/warnings.configure#174-176

# New warning with gcc 9. Not useful
# https://bugzilla.mozilla.org/show_bug.cgi?id=1515356
check_and_add_gcc_warning('-Wno-error=deprecated-copy')
See Also: → 1515356

The header was pulled in indirectly by some cpp file under security/, which sets stricter warning levels.

Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c05a49ce946f
Give EnumSet an assignment operator r=sg
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: