1658075 - Move testing functions from `ChromeUtils.webidl` to `MediaController.webidl`

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

While working in bug1656398, I encoutered a build error if I expose MediaSessionPlaybackState in MediaController.webidl, which conflicts with the ChromeUtilsBinding.

The solution would be move those testing function to MediaController.webidl. And that would give us two benefit. The first, fixing the build error, and the second, we can remove the test-only enum MediaSessionPlaybackTestState.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1658075 - part1 : move testing functions to new namespace 'MediaControlService'.

Create a new namespace MediaControlService to use those helper functions which is used to get the main controller related status.

Then, move those functions from ChromeUtils to MediaControlService, which give us two benefit. The first is that we can remove redudant test-only enum MediaSessionPlaybackTestState, the second is a pref-required work for bug1656398, to fix the build order error when exposing MediaSessionPlaybackState in the media controller's webidl.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1658075 - part2 : use testing functions from 'MediaControlService'.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31940ed110c6
part1 : move testing functions to new namespace 'MediaControlService'. r=smaug,chunmin
https://hg.mozilla.org/integration/autoland/rev/6f80afa46dca
part2 : use testing functions from 'MediaControlService'. r=chunmin

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/31940ed110c6
https://hg.mozilla.org/mozilla-central/rev/6f80afa46dca