1658103 - Tab context menu opened from "Show All Tabs" popup menu, is shown almost blank! in certain cases. (+ code to fix!)

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Javier "Darth"]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

In Nightly 81.0a1 : (also Firefox 78.0.2)

• Make sure you don't move the mouse cursor to tabs-toolbar area ('mouseover' & 'focus' events must not be fired in this area)

• In main menu (ALT + V) do: View -> "Show All Tabs". Also you can click the "List All Tabs" button (taking care of not 'touching' tabs area)
  (In order to enable "Show All Tabs", you may have to open several tabs or reduce window width)

• In "Show All Tabs" popup, just open Tab-context-menu by secondary-click a line in tabs listing.

Nightly 81.0a1, Build ID 20200807213618, Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0

Actual results:

• The Tab-context-menu appeared almost blank (no content in popup)

Technical info + code to fix ! :

  Menuitems are still having [data-lazy-l10n-id] attribute and not [data-l10n-id].

Can be fixed with this:

  In  chrome\browser\content\browser\tabbrowser.js, you can add this: (with matching removeEventListener) 

     this.tabContainer.addEventListener("mouseover", tabContextFTLInserter); 
  +  document.getElementById("allTabsMenu-allTabsView").addEventListener( "ViewShowing", tabContextFTLInserter );

Also, you can test this manual fix in the console:

document.getElementById("allTabsMenu-allTabsView").addEventListener( "ViewShowing", event => {
if( document.querySelector("#tabContextMenu [data-lazy-l10n-id]") ){
window.gBrowser.tabContainer.dispatchEvent( new MouseEvent("mouseover") ); // See "data-lazy-l10n-id" area in tabbrowser.js
}
})

Expected results:

• The Tab-context-menu should appear with all menuitems, the same as when opening It from a tab.

Comment 1

[Javier "Darth"]

I think it should be:

  Component:
  Tabbed Browser ▾

Comment 2

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Indeed, thank you!

Comment 3

[Alice0775 White]

I can reproduce the issue on Nightly81.0a1(20200812034418) Windows10, 79.0 and 80.0b7.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a3695dec8b662cec2ad29f4f6ce1769875b13bb2&tochange=c4669392e7dca7573ecf25da7510f55482dbdce0

Before landing Bug 356980: No tab contextmenu is provided
After landing Bug 356980: Tab contextmenu pops up, and I can reproduce this issue.

So, this is a implementation bug.

Comment 4

[Dão Gottwald [:dao]]

Thanks Javier and Alice!

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 7

[Shane Hughes [:aminomancer]]

Oops, sorry. I'll do this in a minute

Comment 8

[Shane Hughes [:aminomancer]]

Attachment: Bug 1658103 - Fix lazy translation of tab context menu. r=dao

The tab context menu is designed to not be translated until the user
interacts with the tab strip in some way. However, the tab context menu
is now shared between the tab strip and the "all tabs" panel. So, it's
possible to open the tab context menu without interacting with the tab
strip. This results in the context menu being opened before it is
translated, so the user sees an essentially blank menu. Resolve this
by adding to the all tabs panel the same handlers that presently listen
on the tab strip: translate on mouseover, contextmenu & focus events.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/312fd89907d7
Fix lazy translation of tab context menu. r=dao

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/312fd89907d7

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this on Firefox 100.0(20220428192727) on Win10 64-bits. Verified as fixed on Firefox 101.0b7(20220515185854), Nightly 102.0a1(20220515214519) on Win10 64-bits, Ubuntu 20.04 and macOS 11.
Edit: Corrected a typo.