1658657 - compose API function beginForward ignores ComposeDetails

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[speedball]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

A call to
browser.compose.beginForward(msg.id,
"forwardInline",
{ "identityId": identityId });

ignores the identityId. In a

Actual results:

Composer is opened with the default identity selected as sender

Expected results:

The composer should open with the sender that corresponds to the id given in the ComposeDetails param.

The issue is this code in mail/components/extensions/parent/ext-compose.js:

if (type == Ci.nsIMsgCompType.ForwardInline) {
let msgHdr = null;
let msgURI = null;
let hdrIdentity = null;
if (relatedMessageId) {
msgHdr = messageTracker.getMessage(relatedMessageId);
msgURI = msgHdr.folder.getUriForMsg(msgHdr);
}
let newWindowPromise = waitForWindow();
MailServices.compose.OpenComposeWindow(
null,
msgHdr,
msgURI,
type,
0,
hdrIdentity,
null,
null
);

return newWindowPromise;

Instead of assigning null to hdrIdentity in line 73 (let hdrIdentity = null;) it should use resolve the identity for details.identityId and use that:

if (details.identityId !== null) {
if (!extension.hasPermission("accountsRead")) {
throw new ExtensionError(
'Using identities requires the "accountsRead" permission'
);
}

  let identity = MailServices.accounts.allIdentities.find(
    i => i.key == details.identityId
  );
  if (!identity) {
    throw new ExtensionError(`Identity not found: ${details.identityId}`);
  }

  let hdrIdentity = identity;

Comment 1

[Geoff Lankow (:darktrojan)]

Yeah, that's broken. I've tried to patch it up but some things just aren't possible at the moment.

Comment 2

[Geoff Lankow (:darktrojan)]

I've come up with a reasonable work-around, so I'm going to recycle this bug and put it here, since bug numbers are finite and we shouldn't waste them. ;-)

Also I've just realised I didn't read the original message properly and you offered a partial solution. Sorry about that.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1658657 - Fix forwarding inline via API by setting details after the compose window opens. r?mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b8d5b08f8fa6
Fix forwarding inline via API by setting details after the compose window opens. r=mkmelin

Comment 5

[John Bieling (:TbSync)]

Comment on attachment 9182833 [details]
Bug 1658657 - Fix forwarding inline via API by setting details after the compose window opens. r?mkmelin

[Approval Request Comment]
User impact if declined:
In general: Add-on developers can not use the latest fixes and improvements of our WebExtension API.
Specifically this bug: Bug 1658132 (which is an API fix) needs this bug to be uplifted as well.

Testing completed (on c-c, etc.):
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=3cdff293d5d1bd77777f5da371caaa02c4b05de3

Risk to taking this patch (and alternatives if risky):
I hope none

Remark:
The provided try run includes all bugs I want to uplift for TB 78.7 and shows a working patch order.
Bug 1680653 is the first one, who does not have a bug number in the commit message.
This is the second one.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9182833 [details]
Bug 1658657 - Fix forwarding inline via API by setting details after the compose window opens. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 7

[Dave Miller [:justdave]]

Thunderbird 78.7.0:
https://hg.mozilla.org/releases/comm-esr78/rev/6902aa15e2fb