Closed Bug 1659204 Opened 3 years ago Closed 2 years ago

Don't show a heuristic for local search modes at all, and don't show it for engines for empty searches

Categories

(Firefox :: Address Bar, task, P1)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Iteration:
82.2 - Sep 7 - Sep 20
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

Bug 1659204 - Don't show a heuristic in local search modes except for autofill.
47 bytes, text/x-phabricator-request
Details | Review

Clarification from Verdi:

For local search modes, we should not show a heuristic at all. Currently we don't show a heuristic only when the search string is empty.

For engines, we shouldn't show a heuristic when the search string is empty.

Blocks: urlbar-searchshortcuts
See Also: → 1659709
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 82.1 - Aug 24 - Sep 6

Just an update: We now allow autofill in local search modes (bug 1655473), but afaik every other type of heuristic should still not be shown in local search mode.

Priority: P2 → P1
See Also: → 1664527
Depends on: 1665292
Iteration: 82.1 - Aug 24 - Sep 6 → 82.2 - Sep 7 - Sep 20
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c8cb264f283
Don't show a heuristic in local search modes except for autofill. r=mak,harry

Backed out changeset 8c8cb264f283 (bug 1659204) for urlbar related failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=A4Xqz0_USC6BXf2zr507BA.0&searchStr=mochitest-browser-chrome&fromchange=df9e32287e512ef1aae10b956011abf48699448c&tochange=bd77924dc2e3ff1b8d418e84d75c5733b1edaf1f

Backout link: https://hg.mozilla.org/integration/autoland/rev/bd77924dc2e3ff1b8d418e84d75c5733b1edaf1f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316131516&repo=autoland&lineNumber=13070

[task 2020-09-18T23:53:42.722Z] 23:53:42     INFO - TEST-START | browser/components/urlbar/tests/browser/browser_waitForLoadOrTimeout.js
[task 2020-09-18T23:53:42.778Z] 23:53:42     INFO - GECKO(3291) | [Child 3646: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f353ee8ac00 == 1 [pid = 3646] [id = {c9846fd9-c329-404e-822d-dd6840fd87cb}]
[task 2020-09-18T23:53:42.778Z] 23:53:42     INFO - GECKO(3291) | [Child 3646: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x7f353f9db430) [pid = 3646] [serial = 352] [outer = (nil)]
[task 2020-09-18T23:53:42.780Z] 23:53:42     INFO - GECKO(3291) | [Child 3646: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x7f353ee8b000) [pid = 3646] [serial = 353] [outer = 0x7f353f9db430]
[task 2020-09-18T23:53:42.852Z] 23:53:42     INFO - GECKO(3291) | [Child 3646: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x7f353ee92400) [pid = 3646] [serial = 354] [outer = 0x7f353f9db430]
[task 2020-09-18T23:53:42.951Z] 23:53:42     INFO - GECKO(3291) | [Child 3475: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7f3ef0ff5400) [pid = 3475] [serial = 555] [outer = (nil)] [url = https://example.com/browser/browser/components/urlbar/tests/browser/dummy_page.html]
[task 2020-09-18T23:53:42.952Z] 23:53:42     INFO - GECKO(3291) | [Child 3475: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7f3ef0fed800) [pid = 3475] [serial = 557] [outer = (nil)] [url = about:blank]
[task 2020-09-18T23:53:43.335Z] 23:53:43     INFO - GECKO(3291) | [Parent 3291: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 18 (0x7fb394c46f60) [pid = 3291] [serial = 367] [outer = (nil)] [url = about:preferences#search]
[task 2020-09-18T23:53:43.335Z] 23:53:43     INFO - GECKO(3291) | [Parent 3291: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 17 (0x7fb394c47870) [pid = 3291] [serial = 362] [outer = (nil)] [url = about:preferences#search]
[task 2020-09-18T23:53:43.335Z] 23:53:43     INFO - GECKO(3291) | [Parent 3291: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fb392ec9400 == 6 [pid = 3291] [id = {c5d78687-7b91-478d-8122-1a4f271764cc}] [url = about:about]
[task 2020-09-18T23:53:43.364Z] 23:53:43     INFO - GECKO(3291) | [Child 3646: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (0x7f353f3a4400) [pid = 3646] [serial = 355] [outer = 0x7f353f9db430]
[task 2020-09-18T23:53:43.470Z] 23:53:43     INFO - TEST-INFO | started process screentopng
[task 2020-09-18T23:53:43.856Z] 23:53:43     INFO - TEST-INFO | screentopng: exit 0
[task 2020-09-18T23:53:43.856Z] 23:53:43     INFO - Buffered messages logged at 23:53:42
[task 2020-09-18T23:53:43.856Z] 23:53:43     INFO - Entering test bound load
[task 2020-09-18T23:53:43.857Z] 23:53:43     INFO - Buffered messages logged at 23:53:43
[task 2020-09-18T23:53:43.857Z] 23:53:43     INFO - Awaiting for the urlbar panel to open
[task 2020-09-18T23:53:43.858Z] 23:53:43     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_waitForLoadOrTimeout.js | Page should have loaded before timeout - {"isTrusted":true} == true - 
[task 2020-09-18T23:53:43.858Z] 23:53:43     INFO - Buffered messages finished
[task 2020-09-18T23:53:43.858Z] 23:53:43     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_waitForLoadOrTimeout.js | example.com should have loaded - "https://example.com/" == "http://example.com/" - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_waitForLoadOrTimeout.js :: load/< :: line 22
[task 2020-09-18T23:53:43.858Z] 23:53:43     INFO - Stack trace:
[task 2020-09-18T23:53:43.858Z] 23:53:43     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_waitForLoadOrTimeout.js:load/<:22
[task 2020-09-18T23:53:43.858Z] 23:53:43     INFO - Leaving test bound load
[task 2020-09-18T23:53:43.858Z] 23:53:43     INFO - Entering test bound timeout
[task 2020-09-18T23:53:43.858Z] 23:53:43     INFO - GECKO(3291) | [Parent 3291: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 16 (0x7fb394c47de0) [pid = 3291] [serial = 359] [outer = (nil)] [url = about:about]
[task 2020-09-18T23:53:44.611Z] 23:53:44     INFO - GECKO(3291) | [Parent 3291: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 15 (0x7fb393fb3800) [pid = 3291] [serial = 361] [outer = (nil)] [url = about:about]
[task 2020-09-18T23:53:44.611Z] 23:53:44     INFO - GECKO(3291) | [Parent 3291: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (0x7fb39763a400) [pid = 3291] [serial = 369] [outer = (nil)] [url = about:preferences#search]
[task 2020-09-18T23:53:44.611Z] 23:53:44     INFO - GECKO(3291) | [Parent 3291: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (0x7fb39634e000) [pid = 3291] [serial = 364] [outer = (nil)] [url = about:preferences#search]
[task 2020-09-18T23:53:44.916Z] 23:53:44     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_waitForLoadOrTimeout.js | No page should have loaded, and timeout should have fired - true == true - 
[task 2020-09-18T23:53:44.916Z] 23:53:44     INFO - Leaving test bound timeout
[task 2020-09-18T23:53:44.933Z] 23:53:44     INFO - GECKO(3291) | MEMORY STAT | vsize 3687MB | residentFast 526MB | heapAllocated 167MB
[task 2020-09-18T23:53:44.934Z] 23:53:44     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_waitForLoadOrTimeout.js | took 2209ms
Flags: needinfo?(adw)
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/763a0359244d
Don't show a heuristic in local search modes except for autofill. r=mak,harry
Regressions: 1666062

https://hg.mozilla.org/mozilla-central/rev/763a0359244d

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Flags: needinfo?(adw)
You need to log in before you can comment on or make changes to this bug.