1659795 - add fission indicator to topcrashers report and signature report

Status: RESOLVED FIXED

(Socorro :: Webapp, enhancement, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Fission-related triage would benefit greatly from having a Fission indicator in the TopCrashers report and Signature report that worked the same way the Startup Crash indicator works.

This covers that.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5527: bug 1659795: add fission indicators to signature/topcrashers reports

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5527: "bug 1659795: add fission indicators to signature/topcrashers reports" in c7e8f4f.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Chris: What do you think about these?

• TopCrashers report on stage: https://crash-stats.allizom.org/topcrashers/?product=Firefox&version=81.0a1
• Signature report (all fission): https://crash-stats.allizom.org/signature/?product=Firefox&signature=AsyncShutdownTimeout%20%7C%20profile-before-change%20%7C%20JSON%20store%3A%20writing%20data%2CJSON%20store%3A%20writing%20data%2CJSON%20store%3A%20writing%20data%2CJSON%20store%3A%20writing%20data%2CJSON%20store%3A%20writing%20data%2CJSON%20store%3A%20writing%20data%2COS.File%3A%20flush%20I%2FO%20queued%20before%20profileBeforeChange&version=81.0a1&date=%3C2020-08-18T19%3A57%3A20%2B00%3A00&date=%3E%3D2020-08-11T19%3A57%3A20%2B00%3A00
• Signature report (some fission): https://crash-stats.allizom.org/signature/?product=Firefox&signature=AsyncShutdownTimeout%20%7C%20profile-before-change-telemetry%20%7C%20TelemetryController%3A%20shutting%20down&version=81.0a1&date=%3C2020-08-18T19%3A57%3A20%2B00%3A00&date=%3E%3D2020-08-11T19%3A57%3A20%2B00%3A00

Does that help with triaging?

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #3)

Chris: What do you think about these?

Looks good!

Looks like the criteria for "Potential Fission Crash" is num_fission_crashes > 0 and num_fission_crashes < num_crashes. Maybe we should only show "Potential Fission Crash" if num_fission_crashes > num_crashes / 2?

https://github.com/mozilla-services/socorro/pull/5527/commits/33935348a8fbcd5e69b70bc3ed00eddb4a146c36#diff-a7d1c53ffed84fe4a5fee1abc9bd61eaR171-R174

Otherwise we get likely false positives like this crash signature where only 1 out of 3 crashes have Fission enabled. And the report page doesn't mention Fission on the "Correlations" tab. (I don't remember the criteria for Correlations.)

https://crash-stats.allizom.org/signature/?product=Firefox&version=81.0a1&signature=AsyncShutdownTimeout%20%7C%20profile-before-change-telemetry%20%7C%20TelemetryController%3A%20shutting%20down&date=%3E%3D2020-08-11T20%3A18%3A00.000Z&date=%3C2020-08-18T20%3A18%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#summary

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'll change the criteria for "Potential Fission Crash" now.

Correlations is a completely different system that Marco maintains. I don't really know how that works and I'm not sure I'll be able to get it to match what Socorro is doing. (I think that's what you're suggesting.)

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5528: bug 1659795: change criteria for "potential fission crash"

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5528: "bug 1659795: change criteria for "potential fission crash"" in 727e19a.

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #5)

Correlations is a completely different system that Marco maintains. I don't really know how that works and I'm not sure I'll be able to get it to match what Socorro is doing. (I think that's what you're suggesting.)

Understood and not a problem.

Your new changes to is_potential_fission_crash look good.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed just now with bug #1660330. Marking as FIXED.