Closed Bug 1660559 Opened 4 years ago Closed 4 years ago

In bootstrap, initialize the mach virtualenvs early and run `mach artifact` with them (`./mach bootstrap` fails with "ModuleNotFoundError: No module named 'zstandard'")

Categories

(Firefox Build System :: Bootstrap Configuration, task)

task

Tracking

(firefox82 fixed)

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: rstewart, Assigned: rstewart)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Bootstrap Configuration

mach artifact has a dependency on zstandard, which is installed in the mach virtualenvs, so we have to run mach artifact with the correct virtualenv. Also create the virtualenvs earlier in the process to account for this.

This all has a dependency on the existence of a checkout (which has the mach script with all its dependencies on everything else), but after bug 1647792 that's not a concern.

Is this ready to land? It looks like it got r=mhentges on Monday morning.

(It still has r?firefox-build-system-reviewers but mhentges is in that group, so I would assume that review request could be removed.)

Flags: needinfo?(rstewart)

Hey 👋 I appreciate your confidence in me :dholbert, but I just joined the team relatively recently, so I'm in a bit of a "build reviewer in-training" status.
Once we have a review from a more experienced build reviewer, this will probably have some progress again :)

Flags: needinfo?(rstewart)

Ah - thanks for clarifying. :) I'm just looking to address my bug 1660790 itch, and want to be sure this didn't fall through the cracks.

Thanks!

Extending the title so this is easier to find when looking at ./mach busted

Summary: In bootstrap, initialize the mach virtualenvs early and run `mach artifact` with them → In bootstrap, initialize the mach virtualenvs early and run `mach artifact` with them (`./mach bootstrap` fails with "ModuleNotFoundError: No module named 'zstandard'")
Pushed by rstewart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/637126b84cee
In `mach bootstrap`, initialize the `mach` `virtualenv`s early and run `mach artifact` with them r=mhentges,ahal
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: