In bootstrap, initialize the mach virtualenvs early and run `mach artifact` with them (`./mach bootstrap` fails with "ModuleNotFoundError: No module named 'zstandard'")
Categories
(Firefox Build System :: Bootstrap Configuration, task)
Tracking
(firefox82 fixed)
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: rstewart, Assigned: rstewart)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
||
Comment 1•5 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
|
Assignee | |
Comment 2•5 years ago
|
||
mach artifact has a dependency on zstandard, which is installed in the mach virtualenvs, so we have to run mach artifact with the correct virtualenv. Also create the virtualenvs earlier in the process to account for this.
This all has a dependency on the existence of a checkout (which has the mach script with all its dependencies on everything else), but after bug 1647792 that's not a concern.
|
||
Comment 4•4 years ago
|
||
Is this ready to land? It looks like it got r=mhentges on Monday morning.
(It still has r?firefox-build-system-reviewers but mhentges is in that group, so I would assume that review request could be removed.)
|
||
Comment 5•4 years ago
|
||
Hey 👋 I appreciate your confidence in me :dholbert, but I just joined the team relatively recently, so I'm in a bit of a "build reviewer in-training" status.
Once we have a review from a more experienced build reviewer, this will probably have some progress again :)
|
|
||
Comment 6•4 years ago
|
||
Ah - thanks for clarifying. :) I'm just looking to address my bug 1660790 itch, and want to be sure this didn't fall through the cracks.
Thanks!
|
||
Updated•4 years ago
|
|
||
Comment 9•4 years ago
|
||
Extending the title so this is easier to find when looking at ./mach busted
|
||
Comment 10•4 years ago
|
||
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
Description
•