1660917 - Disabled filters showing as enabled in the GUI

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Len F]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

I created email filters, as detailed in my question at https://support.mozilla.org/en-US/questions/1299994

I'm on a Mac.

Actual results:

Some of my email filters did not run. Initially I thought they were running in the wrong order (incorrect). On opening the msgFilterRules.dat to investigate, I found that some had enabled="no" set. In the GUI, all the filters had their checkboxes checked.

Expected results:

In the Message Filters dialog, filters that have enabled="no" should not have their Enabled checkbox checked; all filters with enabled="yes" should have their Enabled checkbox checked.

Comment 1

[Magnus Melin [:mkmelin]]

I can confirm clicking the checkbox next to a filter and reopening Tools | Message Filters, the checkboxes for the enabled column do not stick.
I wonder when this broke. Alice, are you able to get a regression range?

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=b0c9985debc5306d79fff8e7d24e18b03f83d290&tochange=a06bf70755b1cc052b4bb30a292c491d2c7f1541
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=37e052bd233427ba430c094622cd7cb44377752c&tochange=83895192ba27f0ae37ee27eb9524fb4a46bcf3a5

Comment 3

[Magnus Melin [:mkmelin]]

That's surprising...

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1660917-checkbox-fix.patch

I only tested enabling/disabling the filter without re-open the dialog. Disabling removes the checked attribute completely but when we re-open the window it sets checked="false". Now we are on the safe side with explicitly check for checked="true".

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9172102 [details] [diff] [review]
1660917-checkbox-fix.patch

Review of attachment 9172102 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work, thx! r=mkmelin

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9172102 [details] [diff] [review]
1660917-checkbox-fix.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1650791
User impact if declined: No feedback when filter is disabled
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9172102 [details] [diff] [review]
1660917-checkbox-fix.patch

[Triage Comment]
approved for beta

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e772a3dbdfc6
Set on checkboxes an explicit checked="true" to not apply on checked="false". r=mkmelin

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 81.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/7224c568e23b

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9172102 [details] [diff] [review]
1660917-checkbox-fix.patch

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.2.2:
https://hg.mozilla.org/releases/comm-esr78/rev/6b2adbaa9aa3