Closed Bug 1650791 Opened 5 years ago Closed 5 years ago

Make the messagefilter dialogs themeable

Categories

(Thunderbird :: Theme, task)

Product:
Thunderbird
Component:
Theme
Type:
task

Tracking

(thunderbird_esr78 fixed, thunderbird79 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 80.0
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed
thunderbird79 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files, 3 obsolete files)

filter.png
82.91 KB, image/png
Details
1650791-messagefilter-themeable.patch
21.50 KB, patch
aleca
: review+
wsmwk
: approval-comm-beta+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review

Like in other bugs use the themeableDialog.css to make them themeable.

I had to remove the *menupopup > menu:not([disabled="true"])[selected="true"] because this made the selected but no more active menuitems showing the wrong text colour.

In abContactsPanel.css I had to hide the border around the hamburger button in the sidebar, introduced after bug 1649577.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9161608 - Flags: review?(alessandro)
Comment on attachment 9161608 [details] [diff] [review] 1650791-messagefilter-themeable.patch Review of attachment 9161608 [details] [diff] [review]: ----------------------------------------------------------------- Good start, but there are some quirks. The `New` button hover effect shows and extra border and padding that shouldn't be there. Another issue, probably not related to this but we should address, is the icons in the sublist of the menulist don't have any padding start. (screenshot coming)
Attachment #9161608 - Flags: review?(alessandro) → feedback+

global.css applied the padding only on the first level menupopup of the menulist.

Attachment #9161608 - Attachment is obsolete: true
Attachment #9161816 - Flags: review?(alessandro)

Better approach that not makes the type="menu" buttons so ugly.

Attachment #9161816 - Attachment is obsolete: true
Attachment #9161816 - Flags: review?(alessandro)
Attachment #9161939 - Flags: review?(alessandro)

Found an issue where the buttons in a Add-on installation popup haven't the correct height -> fixed.

Attachment #9161939 - Attachment is obsolete: true
Attachment #9161939 - Flags: review?(alessandro)
Attachment #9162247 - Flags: review?(alessandro)
Comment on attachment 9162247 [details] [diff] [review] 1650791-messagefilter-themeable.patch Review of attachment 9162247 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks
Attachment #9162247 - Flags: review?(alessandro) → review+
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 80.0
Comment on attachment 9162247 [details] [diff] [review] 1650791-messagefilter-themeable.patch [Approval Request Comment] User impact if declined: message filters not following the dark theme. There are also improvements for earlier bug. Testing completed (on c-c, etc.): soon on c-c Risk to taking this patch (and alternatives if risky): low
Attachment #9162247 - Flags: approval-comm-esr78?
Attachment #9162247 - Flags: approval-comm-beta?

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/ee9b757dc8d4
Make the messagefilter dialogs themeable. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Comment on attachment 9162247 [details] [diff] [review] 1650791-messagefilter-themeable.patch Approved for beta
Attachment #9162247 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9162247 [details] [diff] [review] 1650791-messagefilter-themeable.patch Approved for esr78 - optimistically. I'll take an action to make sure this is tested during beta smoketest
Flags: needinfo?(vseerror)
Attachment #9162247 - Flags: approval-comm-esr78? → approval-comm-esr78+

Look good on Windows?

Flags: needinfo?(vseerror) → needinfo?(wls220spring)

(In reply to Wayne Mery (:wsmwk) from comment #14)

Look good on Windows?

Looks good on Windows 10 and Ubuntu Linux.

Flags: needinfo?(wls220spring)
Regressions: 1660917
Regressions: 1662585
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: