1661005 - [Windows] An extra scrollbar is displayed in the Password Autocomplete dropdown the first time it is displayed in a session

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: scrollbar on Windows password import autocomplete.gif

[Affected versions]:

• Firefox Nightly 82.0a1, BuildID 20200824215021
• Firefox Beta 81.0b1 BuildID 20200824150741

[Affected Platforms]:

• All Windows

[Prerequisites]:

• Have a clean new profile with no saved or imported logins.
• Have a couple of logins saved in either Chrome or Edge (chromium)

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and navigate to a website that has a saved login in Chrome/Edge.
2. Focus the username filed.
3. Observe the right side of the Password Import Autocomplete dropdown.

[Expected results]:

• Only the import options are displayed.

[Actual results]:

• An extra scrollbar is displayed.

[Notes]:

• The scrollbar is no longer displayed if the dropdown is dismissed and re-triggered.
• The scrollbar is displayed each time the dropdown is displayed in a new session.
• The issue is NOT reproducible on macOS even with the scrollbars set to Always show.
• Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Visual regression for new windows users with importable passwords

Hmm.. I'm guessing this is from the accessibility fix bug 1639173 as it adds a new row vs an icon inside an autocomplete item.

Comment 2

[Ed Lee :Mardak]

Curiously, on my windows 10 vm, padding-bottom: 3px displays no scrollbar https://searchfox.org/mozilla-central/rev/73a14f1b367948faa571ed2fe5d7eb29460787c1/browser/themes/shared/autocomplete.inc.css#26

While 4px does make the scrollbar appear.

While if I force the import suggestion to show on ubuntu 16.04, it does show up at 3px and goes away at 2px. And on macOS 10.15, the scrollbar appears at 5px but not the current 3px or even if I increased to 4px.

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1661005 - [Windows] An extra scrollbar is displayed in the Password Autocomplete dropdown the first time it is displayed in a session r?MattN

Decrease padding by 1px to not show scrollbar on windows, linux or macOS.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dd96ff5fd41
[Windows] An extra scrollbar is displayed in the Password Autocomplete dropdown the first time it is displayed in a session r=MattN

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2dd96ff5fd41

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Mardak, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Ed Lee :Mardak]

Could you verify this on nightly for 81 uplift?

Comment 8

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issue is no longer reproducible using Firefox Nightly 82.0a1 (Build ID: 20200901094542) on Windows 10 x64 and Windows 7.
The scrollbar is no longer displayed.

Comment 9

[Ed Lee :Mardak]

Comment on attachment 9171994 [details]
Bug 1661005 - [Windows] An extra scrollbar is displayed in the Password Autocomplete dropdown the first time it is displayed in a session r?MattN

Beta/Release Uplift Approval Request

• User impact if declined: Scrollbar can appear for some windows users with chrome saved passwords
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1) have at least 1 saved login in chrome

2. create new firefox profile
3. navigate to site with saved chrome login
4. focus login field

expect: no scrollbar on the autocomplete popup

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS change decreasing padding to avoid scrollbar
• String changes made/needed: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171994 [details]
Bug 1661005 - [Windows] An extra scrollbar is displayed in the Password Autocomplete dropdown the first time it is displayed in a session r?MattN

Approved for 81.0b5.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f4f97756a646

Comment 12

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the scrollbar is not displayed by following the STR mentioned in the description using Firefox Beta 81.0b5 (Build ID: 20200901203141) on Windows 10 x64 and Windows 7 x64.