1661631 - Disable `toolkit.telemetry.ecosystemtelemetry.enabled` pending additional reviews

Status: RESOLVED FIXED

(Firefox :: Sync, task)

Description

[Ryan Kelly [:rfkelly]]

We've had some requests for additional review of Account Ecosystem Telemetry before rolling it out more broadly; to avoid putting artificial timeline pressure on that process, let's pref it back off by default.

This will require an uplift to beta.

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: Bug 1661631 - set ecosystem telemetry to disabled by default. r?markh

Comment 2

[Ryan Kelly [:rfkelly]]

[Tracking Requested - why for this release]: This was recently preffed on for 81 in Bug 1659895, but we've had some requests for additional review of the design of Account Ecosystem Telemetry, and I think it would be prudent to pref it back off while those take place.

(There is no concrete vulnerability or anything here, so this doesn't need to be a private bug; just making space for additional diligence)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8fc2cb2dce2
set ecosystem telemetry to disabled by default. r=markh

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b8fc2cb2dce2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this patch for Beta approval.

Comment 6

[Ryan Kelly [:rfkelly]]

Comment on attachment 9172575 [details]
Bug 1661631 - set ecosystem telemetry to disabled by default. r?markh

Beta/Release Uplift Approval Request

• User impact if declined: We'll ship some crypto-related code that isn't as thoroughly reviewed as we'd like; if there turn out to be unforeseen problems in the design then we might end up collecting telemetry data that doesn't have the intended privacy properties.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky, it's a flip of a pref that was designed to allow easily enabling/disabling of the feature.

I checked in my latest nightly and confirmed that the default value of this pref was set to false. I also checked the historical telemetry pings via about:telemetry and confirmed that fresh ecosystem telemetry pings are no longer being sent. I think that's sufficient verification.

• String changes made/needed: no

Comment 7

[Ryan Kelly [:rfkelly]]

Please nominate this patch for Beta approval.

Whoops, thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172575 [details]
Bug 1661631 - set ecosystem telemetry to disabled by default. r?markh

Approved for 81.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b60c499e4cba

Comment 10

[Ryan Kelly [:rfkelly]]

Just noting for completeness, I updated to latest beta data and confirmed that the pref has returned to false by default, and my browser has stopped sending ecosystem pings.