1662129 - Use the ResourceWatcher API to fetch Breakpoints

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

In order to support early breakpoint (bug 1573327), we probably have to introduce a "breakpoint" resource, which will be emitted very early as soon as the process or thread starts.
And to do that, the first step would be to implement a legacy listener which would map ThreadFront's paused and resumed RDP event into resources.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1662129 - [devtools] Introduce breakpoint resource.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).

Comment 3

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/jobs?repo=try&revision=7c8295a23a02208edcf5868327ebd1d79572c3cd

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/jobs?repo=try&revision=5c84fe72b604c236220e6f87dd88a4d8daf9be61

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1662129 - [devtools] Rename ensureSourceActor to waitForSourceActorToBeRegisteredInStore.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1662129 - [devtools] Wait for EVALUATE_EXPRESSIONS actions from browser_dbg-expressions.js

The two "location" expressions being added, removed and re-added
are mixed up in the UI if we don't wait for the evaluation of the first,
before removing and re-adding it.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f4451fcdc25
[devtools] Introduce breakpoint resource. r=nchevobbe,jdescottes
https://hg.mozilla.org/integration/autoland/rev/9974b7eea47b
[devtools] Rename ensureSourceActor to waitForSourceActorToBeRegisteredInStore. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8562cd4f988b
[devtools] Wait for EVALUATE_EXPRESSIONS actions from browser_dbg-expressions.js r=nchevobbe

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3f4451fcdc25
https://hg.mozilla.org/mozilla-central/rev/9974b7eea47b
https://hg.mozilla.org/mozilla-central/rev/8562cd4f988b

Comment 10

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1662129) for causing devtools failures in browser_dbg-pause-points.js a=backout

Backout link: https://hg.mozilla.org/mozilla-central/rev/1a895ef04f9f98bf71265bc9efcc0932ca764f0b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cwebrender%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx1014-64-shippable-qr%2Fopt-mochitest-devtools-chrome-e10s&tochange=488d7ff0470408d2c82881247c037b3c30a1db60&fromchange=8886702307bdc640e64d8dc0da6202b384e6ab76&selectedTaskRun=UlSXeJ8aRIKLzksaYizOng.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327345718&repo=autoland&lineNumber=7725

Comment 11

[Alexandre Poirot [:ochameau]]

So, I'm hitting an intermittent failure on:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/test/mochitest/browser_dbg-pause-points.js#69
Current thread has paused or resumed exception while running:

   await dbg.actions.stepOver(getThreadContext(dbg));

I think it relates to not waiting correctly for full resume.
If I add some more wait code around resume, I'm hitting yet another intermittent, this time even more intermittent:
Error: resume command sent while not paused. Currently attached exception while running the same line of code:

   await dbg.actions.stepOver(getThreadContext(dbg));

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=KazB4SbgT9yIrA1SwYl4OA.0&test_paths=devtools%2Fclient%2Fdebugger%2Ftest%2Fmochitest&revision=46ecdb27c59da99bb90c7975512c1c422b61de25

Unfortunately, I don't reproduce locally, which makes it hard to debug...

Comment 12

[Alexandre Poirot [:ochameau]]

I think the test wasn't waiting correctly for initial pause event, let's see if that's green now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e2d5c9abbb70742be67d13824cd360b9500d51f

Comment 13

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1662129 - [devtools] Wait for initial debugger statement breakpoint in browser_dbg-pause-points.js.

As we weren't waiting for pause when calling the first debugger statement,
things were very much confused in stepOvers. We were asserting the initial debugger statement frame,
while, in stepOvers waiting for the first step over "paused" event.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4c10e3ccf29
[devtools] Introduce breakpoint resource. r=nchevobbe,jdescottes
https://hg.mozilla.org/integration/autoland/rev/83b191c95d22
[devtools] Rename ensureSourceActor to waitForSourceActorToBeRegisteredInStore. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d32a6cd1eb33
[devtools] Wait for EVALUATE_EXPRESSIONS actions from browser_dbg-expressions.js r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0b44fc052838
[devtools] Wait for initial debugger statement breakpoint in browser_dbg-pause-points.js. r=nchevobbe

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a4c10e3ccf29
https://hg.mozilla.org/mozilla-central/rev/83b191c95d22
https://hg.mozilla.org/mozilla-central/rev/d32a6cd1eb33
https://hg.mozilla.org/mozilla-central/rev/0b44fc052838

Comment 16

[Chris Peterson [:cpeterson]]

This completed dt-fission-m3-mvp bug should have Fission Milestone M7 Beta.