Closed Bug 1681699 Opened 3 years ago Closed 3 years ago

Cover testing hitting early breakpoint during a remote iframe load

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(Fission Milestone:M7, firefox87 fixed)

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

Bug 1573327 introduces ways to set the breakpoint before the page starts loading.
That, even for page loaded in distinct remote processes, like fission iframes, or when navigating to another process.

We do not have any test yet that cover correctly hitting breakpoints of iframes using another origin and so loading in a distinct process (aka fission iframes).

Bug 1681698 would be a blocker in order to have this test to pass on fission.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Attachment #9192402 - Attachment description: Bug 1681699 - Cover early breakpoint in remote frame with a test. → Bug 1681699 - [devtools] Cover early breakpoint in remote frame with a test.
Severity: -- → S3
Priority: -- → P3

Just making sure this isn't forgotten if not finished this year

Whiteboard: dt-fission-m3-mvp

Tracking dt-fission-m3-mvp bugs for Fission MVP.

Fission Milestone: --- → MVP
Depends on: 1662129, 1683139

This bugs ends up listing, via its dependencies, all the necessary work to support the earliest breakpoints.
This includes:

  • Initializing the ThreadActor as early as the target starts (bug 1681698)
  • Listen to breakpoints via the ResourceWatcher API, use a legacy listener in order to support order devices (bug 1662129)
  • Then, implement the server side listening via the watcher actor, so that we can emit "paused" as early as the target starts and frontend can receive it correctly (bug 1683139)

It appears necessary to have breakpoints to become resources as with only bug 1681698, the thread actor emits a "paused" event,
but the frontend miss it as the only way to listen for it is on the threadFront, which is only created after the call the ThreadActor.attach. i.e. way after the "paused" event is received by the client.

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Fission Milestone: MVP → M7
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/283763c17ed7
[devtools] Cover early breakpoint in remote frame with a test. r=nchevobbe

Backed out for causing failure on browser_browser_resources_console_messages.js.

https://bugzilla.mozilla.org/show_bug.cgi?id=1681698#c11

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9872c90b4b90
[devtools] Cover early breakpoint in remote frame with a test. r=nchevobbe
Regressions: 1692901
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: