1683139 - Implement breakpoints listening via the ResourceWatcher API on the actor side

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Similar to all bugs under meta bug 1626647, this is about implementing server side listening of breakpoints. The goal here is to be able to observe the breakpoint as early as the target starts running and avoid missing any early breakpoint.
Until this bug is done, we will miss very early breakpoints as the ThreadActor will emit an event, while the frontend isn't listening yet for the paused event.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1683139 - [devtools] Implement breakpoint resource on server side via the watcher actor.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp bugs for Fission MVP.

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/jobs?repo=try&revision=9ca18f4b1036af60f7359aef7a7923bb0e19ca2c

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1683139 - [devtools] Rename BREAKPOINT resource to THREAD_STATE.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1683139 - [devtools] Avoid setting the same breakpoint more than once.

This was causing _priorPause to be reset unexpectedly,
leading to lastPausedPacket being null and missing "paused" THREAD_STATE resource.

Comment 6

[Chris Peterson [:cpeterson]]

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1683139 - [devtools] Test setting many breakpoints on the same line.

I'm also cleaning up things in debugger tests in order to reuse the same helper to check for breakpoints info in the gutter.

Comment 8

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=NULU3xYKTxi4zVTpDFf46Q.0&revision=71a6dda9aa6161d33d1737637ba50e4248ef78d2

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5178ad3905fb
[devtools] Rename BREAKPOINT resource to THREAD_STATE. r=jdescottes,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ea0c6e4ae33d
[devtools] Implement breakpoint resource on server side via the watcher actor. r=nchevobbe,jdescottes
https://hg.mozilla.org/integration/autoland/rev/7d2113bf7e0e
[devtools] Test setting many breakpoints on the same line. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d798378a9823
[devtools] Avoid setting the same breakpoint more than once. r=nchevobbe,jdescottes,devtools-backward-compat-reviewers

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5178ad3905fb
https://hg.mozilla.org/mozilla-central/rev/ea0c6e4ae33d
https://hg.mozilla.org/mozilla-central/rev/7d2113bf7e0e
https://hg.mozilla.org/mozilla-central/rev/d798378a9823