Closed Bug 1662154 Opened 5 years ago Closed 5 years ago

Enable "test_bug551225.html" for xorigin iframes with Fission

Categories

(Core :: DOM: Core & HTML, task, P3)

task

Tracking

()

RESOLVED DUPLICATE of bug 1668357
Fission Milestone M6c

People

(Reporter: mbrodesser, Assigned: mbrodesser)

References

Details

(Whiteboard: waiting on session history)

Attachments

(1 obsolete file)

Doesn't look like a test-failure, needs more investigation:

 0:50.26 TEST_START: http://mochi.test:8888/tests/docshell/test/mochitest/test_bug551225.html
 0:50.81 GECKO(17256) [17556, Unnamed thread 7fba0d98b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:50.81 GECKO(17256) ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpkBJIF5.mozrunner/runtests_leaks.log
 0:50.81 GECKO(17256) [17556, Unnamed thread 7fba0d98b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:50.81 GECKO(17256) [17556, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /home/mirko/src/firefox/gecko2/tools/profiler/core/platform.cpp, line 246
 0:51.70 GECKO(17256) [Parent 17256, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /home/mirko/src/firefox/gecko2/layout/generic/nsFrameSelection.cpp, line 1598
 0:52.23 GECKO(17256) [Child 17420, Main Thread] WARNING: NS_ENSURE_TRUE(mRequest) failed: file /home/mirko/src/firefox/gecko2/netwerk/base/nsBaseChannel.cpp, line 925
 0:55.43 GECKO(17256) [17586, Unnamed thread 7f9b6698b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:55.43 GECKO(17256) ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpkBJIF5.mozrunner/runtests_leaks.log
 0:55.43 GECKO(17256) [17586, Unnamed thread 7f9b6698b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:55.43 GECKO(17256) [17586, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /home/mirko/src/firefox/gecko2/tools/profiler/core/platform.cpp, line 246
 0:58.20 GECKO(17256) [Child 17475, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004002 (NS_NOINTERFACE): file /home/mirko/src/firefox/gecko2/docshell/base/nsDocShell.cpp, line 10798
 0:58.20 GECKO(17256) [Child 17475, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004002 (NS_NOINTERFACE): file /home/mirko/src/firefox/gecko2/docshell/base/nsDocShell.cpp, line 10679
 0:58.21 GECKO(17256) JavaScript error: http://mochi.test:8888/tests/docshell/test/mochitest/test_bug551225.html?currentTestURL=docshell%2Ftest%2Fmochitest%2Ftest_bug551225.html&closeWhenDone=undefined&showTestReport=true&expected=pass, line 25: NS_NOINTERFACE:
 0:58.22 FAIL uncaught exception - NS_NOINTERFACE:  at @http://mochi.test:8888/tests/docshell/test/mochitest/test_bug551225.html?currentTestURL=docshell%2Ftest%2Fmochitest%2Ftest_bug551225.html&closeWhenDone=undefined&showTestReport=true&expected=pass:25:9

Looks like it's failing at history.replaceState, which should have been fixed in Bug 1649131 but this is still behind a pref. Mirko, can you check if enabling fission.sessionHistoryInParent pref fixes it?

Flags: needinfo?(mbrodesser)

Neha: thanks for the hint. The test passes when enabling the pref (./mach mochitest --setpref="fission.sessionHistoryInParent=true" --enable-xorigin-tests --enable-fission ./docshell/test/mochitest/test_bug551225.html).

Will the pref be removed soon, and the default value will be true? Or should the pref be set to true inside the test?

Flags: needinfo?(mbrodesser) → needinfo?(nkochar)

Yes, that pref will be enabled with fission when bug 1656208 lands (also in M6b).

Flags: needinfo?(nkochar)
Summary: Enable "test_bug551225.html" when xorigin iframes and Fission are enabled → Enable "test_bug551225.html" for xorigin iframes with Fission
Assignee: nobody → mbrodesser
Whiteboard: waiting on session history

Mirko has already verified that the test passes with session history pref so enabling the test itself is a trivial task that can be moved to M6c. Nothing to fix here.

Status: NEW → ASSIGNED
Type: defect → task
Fission Milestone: M6b → M6c

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mbrodesser, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mbrodesser)
Flags: needinfo?(mbrodesser)

Already enabled in bug 1668357.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Attachment #9176003 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: