1662167 - Split UrlbarInputHistoryProvider from UnifiedComplete

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Marco Bonardo [:mak] (Away 10-21 August)]

InputHistory (aka AdaptiveHistory) results appear before normal frecency bookmarks/history results, and are completely indipendent from them, so it should be possible to split out their provider.

It may be one of the first time where we split general results, thus it may require some grouping/sorting changes in the muxer.
This would allow also to experiment with shifting their position (Verdi at a certain point said we could evaluate showing them at top results, before search suggestions, in their own group).

Another complexity is currently we run it twice, with MATCH_BOUNDARY and later with MATCH_ANYWHERE if we didn't find enough results, though it doesn't seem necessary, we're already comparing the search string with the stored input string, and limiting the number of results (currently to 1/4 of the results...), we could just match anywhere.

Comment 1

[Harry Twyford]

Attachment: Bug 1662167 - Split UrlbarInputHistoryProvider from UnifiedComplete. r?adw!

Depends on D114896

Comment 2

[Harry Twyford]

Attachment: Bug 1662167 - Part 2 - Remove adaptive query code from UnifiedComplete. r?adw!

Depends on D115735

Comment 3

[Harry Twyford]

Attachment: Bug 1662167 - Part 3 - Modify input history tests to pass.

Depends on D115736

Comment 4

[Harry Twyford]

Attachment: Bug 1662167 - Part 0 - Create necessary helper functions for provider porting. r=adw

Comment 5

[Harry Twyford]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb32f597bdaef3024af11b36449e24b4e673a70f

Comment 6

[Harry Twyford]

https://treeherder.mozilla.org/jobs?repo=try&revision=b03ad71b4efdc538a4f4fe6db47cc49e670db82a&selectedTaskRun=DR5zsydUT3KBjho_CF_cvA.0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/851eb09fedaa
Part 0 - Create necessary helper functions for provider porting. r=adw
https://hg.mozilla.org/integration/autoland/rev/089db3ee29cc
Split UrlbarInputHistoryProvider from UnifiedComplete. r=adw
https://hg.mozilla.org/integration/autoland/rev/74f4ea0db472
Part 2 - Remove adaptive query code from UnifiedComplete. r=adw
https://hg.mozilla.org/integration/autoland/rev/6af229948e19
Part 3 - Modify input history tests to pass. r=adw

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/851eb09fedaa
https://hg.mozilla.org/mozilla-central/rev/089db3ee29cc
https://hg.mozilla.org/mozilla-central/rev/74f4ea0db472
https://hg.mozilla.org/mozilla-central/rev/6af229948e19