Open Bug 1623636 Opened 4 years ago Updated 2 years ago

[meta] Split UnifiedComplete into UrlbarProviders

Categories

(Firefox :: Address Bar, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: bugzilla, Unassigned)

References

(Depends on 3 open bugs, Blocks 2 open bugs)

Details

(Keywords: meta)

One of the long-term goals of the Quantum Bar project is to split UnifiedComplete into many UrlbarProviders. This would make the Urlbar back-end code easier to maintain and create a clearer separation between result-fetching (the Providers) and deduping/muxing.

We'll start with splitting UrlbarProviderSuggestions out from UnifiedComplete. Marco expects this will be the easiest result type to port. This work will give us a better idea of the difficulties we might face as we port other result types into a UrlbarProvider.

See bug 1623160 comment 4 for more discussion of this project. In particular, Marco raises some issues we might encounter:

There are a few things that may end up being problematic:

  1. we have a ton of tests for unifiedcomplete, once we start splitting things out those tests will have to be ported to the urlbar component, many may start breaking, fixing test will take a huge amount of time
  2. once results arrive from many more sources than today, we could hit again the results flickering problem, and then we should start looking into some kind of ui buffering (return results in chunks every 16 ms?). We already have some problem with the multiple providers today, where a result arrives late and pushes down another one (for example the Search in a private window result, some users complains it appeared just when they were about to click on the previous result in that position)
Depends on: 1623637
Priority: -- → P3
Depends on: 1624704

Updating qe tracking flags to reflect QA triage decision taken with :mdeboer in QA-Search weekly sync meeting.

Flags: qe-verify-
Depends on: 1628065
Depends on: 1642710
Depends on: 1645324
Depends on: 1628016
Depends on: 1645521
Depends on: 1648468
Depends on: 1662167
Depends on: 1662172
Depends on: 1677126
Depends on: 1712352
Depends on: 1714409
Depends on: 1715137
Depends on: 1715484
Depends on: 1717507
Depends on: 1717509
Depends on: 1717511
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.