1663005 - If "save to pdf" is selected printer, try to copy over as many current settings as possible to the system dialog.

Status: NEW

(Toolkit :: Printing, enhancement, P2)

Description

[Blake Winton (:bwinton) (:☕️)]

+++ This bug was initially created as a clone of Bug #1661374 +++

As Martin mentions in bug 1661374 comment #11, we should probably do something a little smarter here…

Tagging Shorlander in case UX would like to give some input.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

[Moving front-end printing v82 bugs to v83.]

Comment 2

[Daniel Holbert [:dholbert]]

One manifestation of this bug right now: there's currently no way to do "Print Selection" if you happen to have "Save to PDF" as your printer in the tab-modal print dialog.

STR:

1. Visit http://example.org/
2. Select some text.
3. Ctrl+P
4. Choose "Save to PDF" as the print target.
5. Click "Print using the System Dialog".

ACTUAL RESULTS:
In the system dialog, the "print selection" radio button is disabled (grayed out).

EXPECTED RESULTS:
The radio button should be available, because I selected some content on the page before I started the print operation.

If you adjust step 4 to choose a real printer (not Save to PDF), you get expected results. This all boils down to these lines of JS, which I think are what this bug is about: https://searchfox.org/mozilla-central/rev/35245411b9e8a911fe3f5adb0632c3394f8b4ccb/toolkit/components/printing/content/print.js#215-222
(This code gives us a brand-new print-settings object for the system-print operation, if the print target happens to be save-to-pdf. And since the "is the print-selection radio button available" state is stored as flag on the print-settings object, that means we don't get the correct value of that flag.)

Comment 3

[Jonathan Watt [:jwatt]]

This probably depends on bug 1669149. See bug 1669149 comment 2 in particular.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

(Moving bugs to 86, part 2.)