1663055 - Loss of caret cursor and selection after drag and drop of recipient pills (no visual feedback after drop, prevents verification or error correction)

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot: Hmmm, which pills did I just drop here?? (Hint: it's not Henry Miller!)

+++ This bug was initially created as a clone of Bug #1601749 +++

STR

• Have 10 pills in CC (for purposes of illustration)
• Drag 2 pills from To: field into the middle of CC: field (after pill 5)
• Try to visually verify if you succeeded to drag all pills to target and in correct position
• Observe focus
• Click on To-field (drag-source, empty or with some pills left)

Actual result

• all but impossible to visually verify operation success, because selection is lost and dropped pills immediately blend in with existing pills in target
• focus doesn't follow mouse to drop target (that's a bug)
• click on To-field fails to return caret cursor, which makes it look unresponsive (but focus is actually there, and just typing succeeds) - this is not always reproducable, especially when you keep trying; but I've seen it many times

Expected result

• dropped pills should remain selected in drop target:
  • visual feedback, verify operation success
  • allow easy error correction e.g. for drop in wrong field or change of mind
• focus must follow to drop target (either on the selected pill which had focus before, or on the last selected pill, not on the address input please because that might be far away from drop point)
• click on To-field should return caret cursor (will probably fix itself when you move focus to drop target and keep the selection there).

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot 2: Expected behaviour: keep pill selection after drop

For the sake of illustration, this is the requested behaviour.

Comment 2

[Khushil Mistry [:khushil324]]

I have tried to do it in bug 1663041 as it was related to it. You can check out the patch and give your review/feedback on it.

Comment 3

[Khushil Mistry [:khushil324]]

Thomas, what should we do about this bug after completing bug 1663041?

Comment 4

[Thomas D. (:thomas8)]

(In reply to Khushil Mistry [:khushil324] from comment #3)

Thomas, what should we do about this bug after completing bug 1663041?

Thanks Kushil for the ni. This was a bug in it's own right. I have tested this out in 82.0a1 (2020-09-14) (64-bit) and am happy that you have fixed this perfectly in bug 1663041! (Next time, if you fix selection behaviour, you should also mention that in the commit message). Let's close this accordingly.