1663121 - Canceling the “Save as” modal while printing to file (Save to Pdf, Microsoft Print to PDF & Microsoft XPS document destinations) locks the new UI

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: PrintToPdf.gif

Affected versions

• 82.0a1 (BuildId:20200903151816)
• 81.0b6 (BuildId:20200903205131)

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit
• macOS 10.14

Steps to reproduce

1. Launch Firefox.
2. Access any webpage.
3. Hit Ctrl + P
4. Select the Save to Pdf, Microsoft Print to PDF or the Microsoft XPS document destination.
5. Click Print/Save
6. Cancel the Save As window modal.

Expected result

• The UI remains intractable and displayed since the print action was canceled by the user.

Actual result

• The UI options are locked and the user has to close the UI by pressing the esc keyboard button.

Regression Window

• This is a regression.
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=284e3c053bf57ee8f331b21a90751936ee604482&tochange=0de10c26da552953484a56f0fbdb3ab70196988e
• Possible Regressor: Bug 1659624

Additional Information

• For further information regarding this issue please observe the attached screencast.
• [Suggested Severity] S2

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Emma!

From the Pushlog, I think that Bug 1659624 may have caused this regression.

Can you please take a look?

Thank you!

Comment 2

[Emma Malysz]

Attachment: Bug 1663121, reenable print ui form elements if the user cancels saving a pdf

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c84b2f303275
reenable print ui form elements if the user cancels saving a pdf r=mstriemer

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c84b2f303275

Comment 5

[Hani Yacoub, Desktop QA]

I observed while trying to verify this bug that after closing the Save As window modal the print dialog is also closed. Is this the expected behaviour in this case?

Comment 6

[Emma Malysz]

That was originally our desired behavior, but I filed Bug 1668665 because it does not seem like this should happen.

Comment 7

[Hani Yacoub, Desktop QA]

Thanks for the clarification.
Verified as fixed on Firefox Nightly 83.0a1 (2020-10-01) and on Firefox Nightly 82.0a1 (2020-09-10) on Windows 10 x64, Ubuntu 20.04 x64 and on macOS 10.14 that after closing the Save As window modal the print dialog is also closed also.
As described in Comment 6 this was the originally desired behavior, but Bug 1668665 was filled to fix that.

Comment 8

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1084038