1663124 - Canceling the System dialog closes the new print UI

Status: RESOLVED WORKSFORME

(Toolkit :: Printing, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: SystemModal.gif

Affected versions

• 82.0a1 (BuildId:20200903151816)
• 81.0b6 (BuildId:20200903205131)

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit
• macOS 10.14

Steps to reproduce

1. Launch Firefox.
2. Access any webpage.
3. Hit Ctrl + P
4. Select any destination.
5. Click the “Print using the system dialog” option.
6. Close the system dialog by clicking Cancel.

Expected result

• The UI remains intractable and displayed since the print action was canceled by the user.

Actual result

• The new print UI closes.

Regression Window

• This is a regression.
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=284e3c053bf57ee8f331b21a90751936ee604482&tochange=0de10c26da552953484a56f0fbdb3ab70196988e
• Possible Regressor: Bug 1659624

Additional Information

• For further information regarding this issue please observe the attached screencast.
• [Suggested Severity] S3

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Emma!

From the generated Pushlog, I think that Bug 1659624 may have caused this regression.

Can you please take a look?

Thank you!

Comment 2

[Jonathan Watt [:jwatt]]

Yeah, an explicit window.close() was added in https://phabricator.services.mozilla.com/D89198 where mstriemer said "We should likely close if the system dialog is cancelled to avoid any weird issues for now". I don't expect there should be any issues though. Mark, what did you have on your mind there?

Comment 3

[Emma Malysz]

We plan on closing the print UI when they choose to print using the system dialog (1660665), so once I have a patch up for that, this shouldn't be a problem. If we do think it makes sense to avoid closing the window for the time being, I can get a patch up to fix that

Comment 4

[Mark Striemer [:mstriemer]]

We were having issues before the form was being disabled where I believe once you cancelled the system dialog or cancelled the Microsoft Print to PDF filename picker subsequent clicks on the Print button would open the system dialog.

Initially our plan was the close the dialog when the Print or Open system dialog... inputs were clicked, but we kept the dialog around to avoid closing the preview browser before it was accessed by the platform code.

Comment 5

[Jonathan Watt [:jwatt]]

Now bug 1660665 has landed the tab modal UI is closed when you open the system dialog. So this is kinda WORKSFORME/INVALID now.

Comment 6

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1086427