1663153 - Quick Filter Bar - Continue this Search across all folders - not available

Status: VERIFIED FIXED

(Thunderbird :: Search, defect)

Description

[Anje]

Windows 10

In Thunderbird version 68.12.0 (32bit) - works as expected.
In Quick Filter Bar <Ctrl+Shift+K>type something you know will return no results.
click on any of the Filter messages by options and message pops up 'Continue this search across all folders. Press Enter again to continue your search for: X'
If you press 'Enter/Return' key, the search opens in a new tab as a 'Global Search' <Ctrl+K>.

In Thunderbird 78.2.1 (64bit) - expand search option disappeared.
In Quick Filter Bar type something you know will return no results.
Do not get any helpful message about converting to global search.
Pressing 'Enter' has no effect.
Cannot expand QFB search into a Global Search.

Comment 1

[Wayne Mery (:wsmwk)]

Alice, can you find the regression range?

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=e4dff5cebc88183fb993e949a9dcacaea064ca77&tochange=328093467a6516099d5bdc111f8e3129674b5926
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=035f52aed4427b22facfa883067e298f10ef9e97&tochange=be9a6289486a6f366e431782b84a0c0633f8fec2

Suspect: 0daedafc7c204fc261f746775d24fa7ec81ab3a4 Alessandro Castellani — Bug 1585617 - convert remaining <textbox> usages in JavaScript to using html:input. r=mkmelin

Comment 3

[Wayne Mery (:wsmwk)]

Any ideas about a solution?

Comment 4

[Alessandro Castellani [:aleca]]

I should have a patch for this later this week.
Apologies for the delay.

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: 1663153-quick-filter.diff

This fixes the problem.
The issue was the fact that the focusedElement didn't match anymore the passed node after the de-XBL work done.

Comment 6

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Comment on attachment 9189673 [details] [diff] [review]
1663153-quick-filter.diff

Review of attachment 9189673 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0077bebea2b5
Fix Quick Filter bar not continuing to gloda search when no results are found. r=mkmelin

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9189673 [details] [diff] [review]
1663153-quick-filter.diff

[Approval Request Comment]
Regression caused by (bug #): bug 1585617
User impact if declined: The quick filter search bar doesn't allow continuing to the gloda search if no results are found.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): very low as the error was caused by a missing attribute.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9189673 [details] [diff] [review]
1663153-quick-filter.diff

[Triage Comment]
Approved for beta

Comment 10

[Dave Miller [:justdave]]

Thunderbird 84.0b3
https://hg.mozilla.org/releases/comm-beta/rev/60d2d60d17eb

Comment 11

[WaltS48 [:walts48]]

This is working properly in my testing of the 84.0b3 release candidate on Ubuntu 18.04 LTS.

Comment 12

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Comment on attachment 9189673 [details] [diff] [review]
1663153-quick-filter.diff

[Approval Request Comment]
Minor regression. Should be safe

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9189673 [details] [diff] [review]
1663153-quick-filter.diff

[Triage Comment]
Approved for esr78

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/784c94d4af25

Comment 15

[WaltS48 [:walts48]]

Verifying in the 78.6.1 rc on Windows 10.