Closed Bug 1663179 Opened 1 year ago Closed 1 year ago

Topsite enabled search shortcut should not be displayed when the search engine is default

Categories

(Firefox :: Top Sites, defect, P5)

Firefox 81
Desktop
Unspecified
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox-esr78 --- disabled
firefox80 --- disabled
firefox81 --- affected

People

(Reporter: aflorinescu, Unassigned)

References

(Blocks 2 open bugs)

Details

[Sugested Severity:]

S3

[Description:]

According to bug 1545110, when the default search engine and the topsite set as a search shortcut are a match, the topsite should not be displayed in the topsites even if specified in the top-sites configuration.

[Environment:]

Mac 10.14.6 / Windows 10
81.0b6 20200903205131

[Steps:]
  1. Add https://google.com as a topsite in the Remote Settings configuration.
  2. From the Remote Settings configuration, set the https://google.com to be a search shortcut.
  3. Publish the changes and set Firefox to connect to the respective collection.
  4. Set an Firefox profile to connect to the configuration while switching the browser.topsites.useRemoteSetting to true.
  5. Start-up Firefox with the above profile configuration.
[Actual Result:]

Firefox has default search engine google
Firefox has a topsite with search shortcut enabled : google

[Expected Result:]

Firefox has default search engine google
Firefox doesn't have a topsite with search shortcut enabled : google

[Note:]
Taking into account the search mode from Improved Vertical Search, I'm also taking into account that this might be an invalid bug.

Can you please check again after bug 1661008?

Depends on: 1661008
Flags: needinfo?(adrian.florinescu)

I might've mixed two bugs into one.

  1. bug 1545110 states that the AS would not list a default engine as a topsite if it comes from history. So, I'm thinking that for the same reasons as in bug 1545110, we shouldn't allow a RS default topsite if the search engine matches the topsite.

  2. but, default search engines can change, in which case we'd want to list back the topsite and in case the topsite is set as a search shortcut, it should be marked as one and pinned.

bug 1661008 fixes 2nd point item.

Flags: needinfo?(adrian.florinescu)
Flags: needinfo?(dao+bmo)

(In reply to Adrian Florinescu [:aflorinescu] from comment #2)

I might've mixed two bugs into one.

  1. bug 1545110 states that the AS would not list a default engine as a topsite if it comes from history. So, I'm thinking that for the same reasons as in bug 1545110, we shouldn't allow a RS default topsite if the search engine matches the topsite.

  2. but, default search engines can change, in which case we'd want to list back the topsite and in case the topsite is set as a search shortcut, it should be marked as one and pinned.

bug 1661008 fixes 2nd point item.

Okay, can you either morph this bug into covering point 1 only, or close this and file a new one?

Flags: needinfo?(dao+bmo) → needinfo?(adrian.florinescu)
See Also: → 1663630

(In reply to Dão Gottwald [::dao] from comment #3)

Okay, can you either morph this bug into covering point 1 only, or close this and file a new one?

For better clarity, I filled bug 1663630. I will close this one towards the end of the pre-release test run (in order to cover regression scenarios and multiple OSes)

Flags: needinfo?(adrian.florinescu)
Priority: -- → P5
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.