1663467 - [macOS 11 Beta] Close tab 'x' button does not highlight on hover on macOS 11 Beta 9

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect, P1)

Description

[Haik Aftandilian [:haik]]

Attachment: Tab close icon not highlighting on hover on macOS Beta 6 (20A5364e)

The tab close icon does not highlight on hover on macOS Beta 6 (20A5364e). See screenshot.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

I've noticed another symptom, which is probably part of the same bug:

None of the (non-current) tabs highlight unless you hover the mouse over the very lowest part of the tab. This is new with Beta 6 -- I didn't see it in Beta 5.

There's also weirdness clicking on non-current tabs: Sometimes they become current and sometimes they don't. But so far I haven't been able to characterize the problem more precisely than that.

I'd bet this has to do with the native title bar, which has long been covered up by Mozilla's tabs. Specifically, I suspect the tabs don't highlight unless you hover over the part of the tab that extends below the native title bar.

Comment 2

[Haik Aftandilian [:haik]]

(In reply to Steven Michaud [:smichaud] (Retired) from comment #1)

I've noticed another symptom, which is probably part of the same bug:

None of the (non-current) tabs highlight unless you hover the mouse over the very lowest part of the tab. This is new with Beta 6 -- I didn't see it in Beta 5.

I'd bet this has to do with the native title bar, which has long been covered up by Mozilla's tabs. Specifically, I suspect the tabs don't highlight unless you hover over the part of the tab that extends below the native title bar.

Thanks. I wondered if this could be a change in Beta 6 that affected other applications, but I tested some that also have UI in the title bar area and they don't seem to be affected.

Using the "Customize..." option and turning on "Drag Space" lowers the tab bar slightly and that makes more of the tab responsive to hover which is consistent with your theory.

Comment 3

[Haik Aftandilian [:haik]]

@mstange, it looks like you've worked on some title bar area bugs in the past and might have some ideas about this.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Using the "Customize..." option and turning on "Drag Space" lowers the tab bar slightly and that makes more of the tab responsive to hover which is consistent with your theory.

And choosing "Title Bar" instead of "Drag Space" makes the bug go away completely. Likewise for bug 1663483.

Comment 5

[Haik Aftandilian [:haik]]

[Tracking Requested - why for this release]:
Critically usability bug. Sometimes clicking on a tab (depending on where it is clicked) does not trigger a tab switch and tabs don't highlight correctly on hover.

This may turn out to be a macOS bug.

Comment 6

[Markus Stange [:mstange]]

This reminds me of a very similar bug that was present in a Beta build of 10.15, a year ago: bug 1589518. It was fixed in a subsequent build after we reported it.
Is this the same bug? If so, we should file another bug report for Apple, like bug 1589518 comment 11.

Comment 7

[Haik Aftandilian [:haik]]

(In reply to Markus Stange [:mstange] (on PTO until Sep 9) from comment #6)

This reminds me of a very similar bug that was present in a Beta build of 10.15, a year ago: bug 1589518. It was fixed in a subsequent build after we reported it.
Is this the same bug? If so, we should file another bug report for Apple, like bug 1589518 comment 11.

Yes, it looks like the very same bug! I have a mail drafted for our Apple contact, but wanted to get your take on it first. I'll file a new issue in Feedback Assistant and let our Apple contact know about it.

Comment 8

[Ultra Dev]

The error does not occur when you are in full screen.

Comment 10

[Markus Stange [:mstange]]

(In reply to Haik Aftandilian [:haik] from comment #7)

I'll file a new issue in Feedback Assistant and let our Apple contact know about it.

Thank you!

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! I've also noticed that the New Tab button(+) is not highlighted on hover only if the pointer is positioned on the lowest part of the button.

Comment 12

[sorenpearson]

(In reply to Ultra Dev from comment #8)

The error does not occur when you are in full screen.

I'm experiencing the same issue where when I click on a tab it doesn't go to that tab but it works in full screen just fine. Big Sur build 20A5364e.

I'm glad to hear that you are in touch with Apple about this.

Comment 13

[dillmann]

Same problems as everybody, Big Sur build 20A5364e. Filed a bug report with apple too. Didn't realize the full screen fix until someone mentioned that, but I already submitted the report. Will file a comment.

Comment 14

[Ultra Dev]

Fixed in Beta 7!

Comment 15

[Haik Aftandilian [:haik]]

(In reply to Ultra Dev from comment #14)

Fixed in Beta 7!

Thanks! I can confirm that. The problem is no longer reproducible for me with macOS 11 Beta 7 (20A5374g) released today. I've tested Firefox 80, 81, and 82. Closing the bug.

If you are still running into this bug, please make sure you have the latest Beta installed and check your OS version with the Apple Menu -> "About This Mac" and include the version string here.

Marking this bug as resolved "WORKSFORME" now that the fix appears to be in Beta 7.

Comment 18

[Andrew Moff]

This bug has returned along with issue switching tabs and opening new tab via the tab bar in Big Sur Beta 9

Comment 19

[Steven Michaud [:smichaud] (Retired)]

This bug has returned along with issue switching tabs and opening new tab via the tab bar in Big Sur Beta 9

I can confirm this. I tested with Firefox 81, with neither "Title Bar" nor "Drag Space" set on the "Customize" page. Once again, the bug goes away if you choose "Title Bar".

Comment 20

[Haik Aftandilian [:haik]]

We've reported the regression in Big Sur Beta 9 to Apple.

Comment 24

[Markus Stange [:mstange]]

It's interesting that the current incarnation of this bug does not block the entire width of the titlebar - it only blocks the area of the titlebar that would be covered by the window title. So, depending on which tab you have selected, the title of the page that's currently loaded in that tab determines how much of the tab bar is unclickable.

Comment 25

[Markus Stange [:mstange]]

Actually, there's two parts to it. The area where mouseover effects work is different from the area where clicks work. Mouseover is blocked from the entire width of the titlebar, clicks are only blocked where the title text would show.

Comment 26

[Markus Stange [:mstange]]

Let's make this bug about the hover feedback, and let's use bug 1669866 for the fact that clicks don't work.

Comment 27

[Steven Michaud [:smichaud] (Retired)]

This bug seems be fixed once again in macOS 11 Beta 10 (build 20A5395g).