Closed Bug 1664053 Opened 4 years ago Closed 4 years ago

Show the Other Bookmarks folder in the bookmarks bar when bookmarks are stored in the Other Bookmarks folder

Categories

(Firefox :: Bookmarks & History, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox84 --- verified

People

(Reporter: jaws, Assigned: mtigley)

References

Details

Attachments

(4 files)

To increase access to the bookmarks stored in the Other Bookmarks folder, we should display the Bookmarks Folder in the bookmarks toolbar if there are bookmarks stored in Other Bookmarks. If there are no bookmarks stored in the folder then this item will be removed. The "Other Bookmarks" folder will appear at the end of the bookmarks toolbar, and will not get overflowed.

Assignee: jaws → mtigley
Attachment #9183081 - Attachment description: Bug 1664053 - Use unfiled bookmarks icon for Other Bookmarks button in toolbar. r?jaws → Bug 1664053 - Add a margin between the Other Bookmarks button's label and image in toolbar. r?jaws
Attachment #9183081 - Attachment description: Bug 1664053 - Add a margin between the Other Bookmarks button's label and image in toolbar. r?jaws → Bug 1664053 - Update "Other Bookmarks" to use the folder icon. r?jaws
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ae93e1c8b86
Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws
https://hg.mozilla.org/integration/autoland/rev/7ead316c420d
Update "Other Bookmarks" to use the folder icon. r=jaws
Attachment #9184626 - Attachment description: Bug 1664053 - Change class names for Other Bookmarks button to use its own. r?jaws → Bug 1664053 - Update test for dragging tabs to bookmarks toolbar. r?jaws
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fac762d7d7d1
Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws
https://hg.mozilla.org/integration/autoland/rev/212096ca818d
Update "Other Bookmarks" to use the folder icon. r=jaws
https://hg.mozilla.org/integration/autoland/rev/c0af63f82f43
Update test for dragging tabs to bookmarks toolbar. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Flags: needinfo?(mtigley)
Regressions: 1674539
Depends on: 1674756
Blocks: 1674801
No longer depends on: 1674756
Blocks: 1674840
Regressions: 1674756

I have tons of stuff in here, lots of old docs and bugzilla links. Can I delete this or will that delete bookmarks I have stored in other locations? Maybe it was populated via Sync? (I have never stored anything in this folder.) Very confusing having this show up on my bookmarks toolbar and no way to clear or get rid of it.

(In reply to Jim Mathies [:jimm] from comment #8)

I have tons of stuff in here, lots of old docs and bugzilla links. Can I delete this or will that delete bookmarks I have stored in other locations? Maybe it was populated via Sync? (I have never stored anything in this folder.) Very confusing having this show up on my bookmarks toolbar and no way to clear or get rid of it.

"Other Bookmarks" was the default location when bookmarks were created. Bookmarks that you delete from that folder will be deleted from the Other Bookmarks folder that can also be accessed through the Bookmarks Menu and the Library.

Hello,

Verified this issue on Fx 84.0b1 on Win 10, ubuntu and mac os.

Status: RESOLVED → VERIFIED

The "Other Bookmarks" folder suddenly appeared on my Bookmarks Toolbar recently. (I noticed it tonight, but it may have been there for a day or so. My Firefox automatically updated last night, so I suspect the change came through the update.) This folder does NOT need to be on the Toolbar unless I specifically put it there. It should be on the drop-down menu when I click on "Bookmarks" from the main Menu Bar, but the Bookmarks Toolbar only needs specific sites which are accessed frequently. I have found how to change the setting in about:config (set browser.toolbars.bookmarks.2h2020 value to "false"), and that has fixed the problem. However, showing the folder after all of these years does NOT need to be the default. We should have the option of dragging specific bookmarks and/or folders to the toolbar.

This folder on my toolbar was blocking access to a button I frequently use and forced it to be hidden under the double-arrow overflow drop-down. If you are going to put the "Other Bookmarks" button on the toolbar, or any other folder, you should at least let us move the folder to the overflow button and let us show frequently accessed bookmarks on the main section of the toolbar.

(In reply to ajpeavler from comment #11)

This folder does NOT need to be on the Toolbar unless I specifically put it there.

This is a new default which we believe will help users. From Firefox 85 which is out in a couple of weeks, you'll be able to right-click on it and uncheck "Show other Bookmarks" to remove it.

From How to remove the new "Other Bookmarks" button from Firefox | ZDNet (2021-01-20):

… appears to the right of the Firefox bookmarks toolbar. …

Please, does this explain the "dead space" that makes Firefox 85 unusable for me?

From https://discourse.mozilla.org/t/when-will-a-toolbar-api-for-webextensions-be-available/34281/14?u=grahamperrin

… so wide that the end of the address bar, the tools overflow menu and the scrollbar fall beyond the boundary of my screen …

(In reply to Graham Perrin from comment #13)

Created attachment 9199462 [details]
Screen recording of Firefox 84.0.2 – without the 'Other Bookmarks' button

From How to remove the new "Other Bookmarks" button from Firefox | ZDNet (2021-01-20):

… appears to the right of the Firefox bookmarks toolbar. …

Please, does this explain the "dead space" that makes Firefox 85 unusable for me?

In 85 you can remove the "Other Bookmarks" button by right-clicking on it and deselecting "Show Other Bookmarks".

If that is not your issue, please file a new bug with a clear description of what exactly is wrong, maybe a screenshot highlighting the specific issue would help.

Thank you, re: the thread in Mozilla Discourse I suspect that the dead space (space that is problematic) occurs in the absence of the Other Bookmarks button.

I hope to find a workaround, or resolution, without an additional bug report.

The overarching problem is bug 1215064 where comments are restricted.

(In reply to Mark Banner (:standard8) from comment #12)

(In reply to ajpeavler from comment #11)

This folder does NOT need to be on the Toolbar unless I specifically put it there.

This is a new default which we believe will help users. From Firefox 85 which is out in a couple of weeks, you'll be able to right-click on it and uncheck "Show other Bookmarks" to remove it.

Thank you for the explanation; however, I found it to be a PROBLEM, not a help. I found a way to remove it in Firefox 84 via an internet search; the information was out there because I wasn't the only one who thought it was a problem. So I would suggest you reconsider this change. Maybe it would be nice to be able to drag ANY bookmark folder to the toolbar; however, IMO it should be completely blank by default, and the folders should spill over to the overflow section if we would rather have something else in front of them. At least you are going to make the folder easier to remove when 85 comes out.

Regressions: 1695575
No longer regressions: 1695575

The "Other Bookmarks" folder suddenly reappeared in the Bookmarks Toolbar today, after Firefox updated to version 95.0 yesterday. (Maybe it showed up sometime yesterday but I didn't notice it because I wasn't looking for the other items the button obscured on the toolbar.) I had set the preference all these months ago and it was working fine until now. You need to make sure our preferences are saved for future updates! I still don't see how adding this folder by default helps anybody. It's also hard to find how to hide the folder, because one needs to click on a black space on the toolbar, and my toolbar is full when the folder is showing.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: