1674840 - [New Bookmarks performance] Only add Other Bookmarks button when needed

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Micah [:mtigley] (she/her)]

The "Other Bookmarks" folder is automatically part of the toolbar DOM. It would be ideal if we could add this folder dynamically when it's first needed instead.

This issue should make it so that we only insert the Other Bookmarks folder once items are stored in it.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 1674840 - Add Other Bookmarks folder to toolbar dynamically. r=Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2eb02d6cba44
Add Other Bookmarks folder to toolbar dynamically. r=Gijs,fluent-reviewers

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2eb02d6cba44

Comment 4

[Daniel Bodea [:danibodea]]

How exactly should this fix be verified?
The "Other Bookmarks" button from the Bookmarks Toolbar is only displayed when a Bookmark is saved in the Other Bookmarks folder, even on builds prior top the fix.
The Folder appears as created even if it is empty, in the Library window, even on builds prior to the fix.

Comment 5

[:Gijs (he/him)]

This fix doesn't impact behaviour, it was an internal code optimization and shouldn't be verified.