1664761 - Search Messages (Ctrl+Shift+F) from Gloda Search results fails. Error gCurrentFolder is null in SearchDialog.js

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: Search Messages > Choose Folder…

Search for a message using Ctrl+K and select a message from the global search results. A new tab opens with the selected thread or message.
Now press Ctrl+Shift+F or use menu Edit > Find > Search Messages.
The Search Messages window opens, but no folder is selected and there are no buttons to add/remove search criteria.
The error console shows error gCurrentFolder is null (SearchDialog.js:334:7).

Comment 1

[Magnus Melin [:mkmelin]]

Looks like the if-clause should also check that a folder was passed
https://searchfox.org/comm-central/rev/abd622ea3487f41f98871b9cfc9e0a19cf61b595/mail/base/content/SearchDialog.js#278

Comment 2

[Wayne Mery (:wsmwk)]

Reproduces in 78.
See also bug 1248522

Comment 3

[Lasana Murray]

Attachment: 1664761.patch

When in a synthetic view, displayedFolder is null. This patch uses gFolderTreeView.getSelectedFolders() to select the first folder for the search dialog. It does not look like that dialog is meant to work without a folder being specified.

Comment 4

[Lasana Murray]

Try run in progress:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=98796015aac4279e5e9cfab535efef2901c2cc2f

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9181823 [details] [diff] [review]
1664761.patch

Review of attachment 9181823 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f34ae3f49ed
Use a selected folder when opening the search dialog from a synthetic view. r=mkmelin

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9181823 [details] [diff] [review]
1664761.patch

[Approval Request Comment]
User impact if declined: per bug summary
Testing completed (on c-c, etc.): on beta
Risk to taking this patch (and alternatives if risky): covered by test

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9181823 [details] [diff] [review]
1664761.patch

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/6d703a58a137

Comment 10

[Rob Lemley [:rjl]]

This patch causes test failures on all platforms on esr78 (78.4.1). The issue is in the test itself. folder.deleteSelf() from bug 1612239 did not land in comm-central until 2020-09-18. That bug can't be uplifted, can you adjust the test?

Comment 11

[Magnus Melin [:mkmelin]]

Instead of folder.deleteSelf() for 78 it should be

folder.parent.deleteSubFolders(	
    toXPCOMArray([folder], Ci.nsIMutableArray),	
    null	
  );

Comment 12

[Rob Lemley [:rjl]]

Backout 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/f2b63ce60a90

Comment 13

[Lasana Murray]

Attachment: bug1664761.patch

Here is an updated version of the patch for esr-78.

Comment 14

[Lasana Murray]

Couldn't get an artifact build locally to test this but pushed something to the try server here:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=0c04ab287a6fa88f8c3abebd594b834d5e195df5

Comment 15

[Magnus Melin [:mkmelin]]

Comment on attachment 9185728 [details] [diff] [review]
bug1664761.patch

Review of attachment 9185728 [details] [diff] [review]:
-----------------------------------------------------------------

Didn't test it but looks ok to me.

Comment 16

[Rob Lemley [:rjl]]

Comment on attachment 9185728 [details] [diff] [review]
bug1664761.patch

[Triage Comment]
Rebased version of previously approved uplift to work around lack of folder.selfDelete.

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/da1c43d5c412

Comment 18

[Rob Lemley [:rjl]]

Attachment: image.png

Yup, should have made sure that the tests ran.

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/1d4c73485e55