Search Messages (Ctrl+Shift+F) from Gloda Search results fails. Error gCurrentFolder is null in SearchDialog.js
Categories
(Thunderbird :: Search, defect)
Tracking
(thunderbird_esr68 wontfix, thunderbird_esr78+ fixed, thunderbird83 wontfix)
People
(Reporter: nONoNonO, Assigned: lasana)
Details
Attachments
(4 files)
36.88 KB,
image/png
|
Details | |
5.94 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
5.39 KB,
patch
|
mkmelin
:
review+
rjl
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
3.25 KB,
image/png
|
Details |
Search for a message using Ctrl+K and select a message from the global search results. A new tab opens with the selected thread or message.
Now press Ctrl+Shift+F or use menu Edit > Find > Search Messages.
The Search Messages window opens, but no folder is selected and there are no buttons to add/remove search criteria.
The error console shows error gCurrentFolder is null (SearchDialog.js:334:7).
Comment 1•4 years ago
|
||
Looks like the if-clause should also check that a folder was passed
https://searchfox.org/comm-central/rev/abd622ea3487f41f98871b9cfc9e0a19cf61b595/mail/base/content/SearchDialog.js#278
Comment 2•4 years ago
|
||
Reproduces in 78.
See also bug 1248522
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
When in a synthetic view, displayedFolder is null. This patch uses gFolderTreeView.getSelectedFolders()
to select the first folder for the search dialog. It does not look like that dialog is meant to work without a folder being specified.
Assignee | ||
Comment 4•4 years ago
|
||
Comment 5•4 years ago
|
||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7f34ae3f49ed
Use a selected folder when opening the search dialog from a synthetic view. r=mkmelin
Comment 7•4 years ago
|
||
Comment on attachment 9181823 [details] [diff] [review]
1664761.patch
[Approval Request Comment]
User impact if declined: per bug summary
Testing completed (on c-c, etc.): on beta
Risk to taking this patch (and alternatives if risky): covered by test
Comment 8•4 years ago
|
||
Comment on attachment 9181823 [details] [diff] [review]
1664761.patch
[Triage Comment]
Approved for esr78
Comment 9•4 years ago
|
||
bugherder uplift |
Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/6d703a58a137
Comment 10•4 years ago
|
||
This patch causes test failures on all platforms on esr78 (78.4.1). The issue is in the test itself. folder.deleteSelf() from bug 1612239 did not land in comm-central until 2020-09-18. That bug can't be uplifted, can you adjust the test?
Comment 11•4 years ago
|
||
Instead of folder.deleteSelf() for 78 it should be
folder.parent.deleteSubFolders(
toXPCOMArray([folder], Ci.nsIMutableArray),
null
);
Comment 12•4 years ago
|
||
backout bugherder uplift |
Backout 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/f2b63ce60a90
Assignee | ||
Comment 13•4 years ago
|
||
Here is an updated version of the patch for esr-78.
Assignee | ||
Comment 14•4 years ago
|
||
Couldn't get an artifact build locally to test this but pushed something to the try server here:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=0c04ab287a6fa88f8c3abebd594b834d5e195df5
Comment 15•4 years ago
|
||
Updated•4 years ago
|
Comment 16•4 years ago
|
||
Comment on attachment 9185728 [details] [diff] [review]
bug1664761.patch
[Triage Comment]
Rebased version of previously approved uplift to work around lack of folder.selfDelete.
Comment 17•4 years ago
|
||
bugherder uplift |
Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/da1c43d5c412
Comment 18•4 years ago
|
||
Yup, should have made sure that the tests ran.
Comment 19•4 years ago
|
||
bugherder uplift |
Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/1d4c73485e55
Description
•