1666637 - [RTL] The new PIP toggle points in the wrong direction, even for RTL documents

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Itiel]

The icon was mirrored in bug 1598886.
After bug 1664899 the arrow in the PIP toggle icon is pointing to the right, while in fact the PIP window appears on the left side for RTL.

While fixing this, it'd be nice to mirror the icon for all documents, maybe by detecting Services.locale.isAppLocaleRTL and setting a rtl class on the toggle. Then mirroring can be done by targeting the .rtl class, or something.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1664899

Comment 2

[:Gijs (he/him)]

We have to be a little careful here because the toggle now contains introductory text the first time it is shown, and we won't want to mirror that, flipping the (likely already RTL, because localized) text...

Comment 3

[Reid Shinabarker]

Attachment: Bug 1666637 - [RTL] The new PIP toggle points in the wrong direction, even for RTL documents r?mconley,gijs

Comment 4

[Reid Shinabarker]

Attachment: Bug 1666637 - [RTL] The new PIP toggle points in the wrong direction, even for RTL documents r?mconley,gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8d334522777
[RTL] The new PIP toggle points in the wrong direction, even for RTL documents r=mconley,Gijs

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a8d334522777

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:reidshina6, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Aleksander Machniak]

I have the same issue not with RTL, but when the video element uses transform: rotateY(180deg); It causes the PiP icon and text to be flipped.

I think this is commonly used by some conferencing software to display a mirrored picture of the user itself. Will that be fixed too? Should I open a new ticket?

Another issue with this technique is that the PiP video is not rotated as the original was.

Comment 9

[Itiel]

(In reply to Aleksander Machniak from comment #8)

I have the same issue not with RTL, but when the video element uses transform: rotateY(180deg); It causes the PiP icon and text to be flipped.

I think this is commonly used by some conferencing software to display a mirrored picture of the user itself. Will that be fixed too? Should I open a new ticket?

Another issue with this technique is that the PiP video is not rotated as the original was.

I think this is covered in bug 1668863.

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly build from 2020-09-22, verified that using RTL builds of Firefox 85.0b2 across platforms (Windows 10 64bit, macOS 11 and Ubuntu 18.04) the icon from PiP is indicating the correct place where the video window will open.