1665115 - Alias gets readded to addressbar after being translated into search-mode indicator

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

[Sugested Severity:]

S4

[Description:]

An edge case when the @shortcut is translated to search-mode indicator and the @alias is readded.

[Environment:]

Ubuntu 20.04 / Windows 10 / Mac 10.13.6
82.0a1 2020-09-15

[Steps:]

1. Open Firefox.
2. New tab.
3. type @google+space -> alias gets transformed into search-mode indicator.
4. Press + to create a new tab.
5. Navigate back to the step 3 tab.

[Actual Result:]

google search mode-indicator + @google present in the tab.

[Expected Result:]

google search mode-indicator

[Regression Range]

On 81.0 2020-09-14, flipping the Browser.urlbar.update2.* prefs, the issue doesn't reproduce, so I'd guess it's a regression caused by bug 1647890.

I'll get back with a confirmed regression range at a later point.

Comment 1

[Drew Willcoxon :adw]

I bet we're restoring userTypedValue. We need to null it when it's converted into the search mode indicator -- or it might not be quite that simple. It may be more like, we need to remove the prefix that got converted into the indicator.

I wonder whether we could rely on this behavior to restore search mode per tab, instead of needing the map that we use now. When we added that map, bug 1658964 hadn't yet landed and fixed the problem where aliases at the beginning of the input value weren't converted to search mode.

Typing @google test (i.e., with a query after the alias) seems to work correctly. Pasting it doesn't, so we should be sure to fix that too.

Comment 2

[Adrian Florinescu [:aflorinescu]]

(In reply to Drew Willcoxon :adw from comment #1)

Typing @google test (i.e., with a query after the alias) seems to work correctly. Pasting it doesn't, so we should be sure to fix that too.

Pasting @google query_string works for me.

Comment 3

[Alin Ilea, Desktop Test Engineering]

Regression range obtained by me:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2e2abe718eb21d36932b373f587d11819d0a3674&tochange=6c384e44f2e40426da3fbdcc044ac300206b9850

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:adw, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 5

[Julien Cristau [:jcristau]]

Calling this fix-optional for 82 given the S4 severity.

Comment 6

[Mathew Hodson]

browser.urlbar.update2.* prefs are only enabled n Nightly.

Comment 7

[Drew Willcoxon :adw]

Attachment: Bug 1665115 - Update userTypedValue when entering search mode so that search strings are properly restored.

Comment 8

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe265340eada0ea1b4dd0cfca6b563e111d2fe6c

Comment 9

[Drew Willcoxon :adw]

Attachment: Bug 1665115 - Add a test to make sure search mode is duplicated when duplicating tabs.

Comment 10

[Phabricator Automation]

Comment on attachment 9181166 [details]
Bug 1665115 - Add a test to make sure search mode is duplicated when duplicating tabs.

Revision D93293 was moved to bug 1659203. Setting attachment 9181166 [details] to obsolete.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/582e4890127f
Update userTypedValue when entering search mode so that search strings are properly restored. r=mak

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/582e4890127f