Closed Bug 1665138 Opened 5 years ago Closed 5 years ago

Make 7 rows default

Categories

(Firefox :: New Tab Page, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
83 Branch
Iteration:
83.1 - Sept 21 - Oct 4
Tracking Status
firefox82 - verified
firefox83 + verified

People

(Reporter: gsuntop, Assigned: thecount)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

make default the 7 rows since we’re now live in all markets with the 7 row layout

Assignee: nobody → gsuntop
Assignee: gsuntop → sdowne
Iteration: 82.2 - Sep 7 - Sep 20 → 83.1 - Sept 21 - Oct 4
Priority: P1 → P2
Depends on: 1660035

[Tracking Requested - why for this release]: Similar to bug 1666892, once our global English feed experiment is done, we'll want this in 82.

CCing Julien, the 82 release owner

I don't think I need to track this.

To test:

  1. Create a new profile in an English browser.
  2. Ensure you see newtab stories, and that you see 7 rows.
  3. Change browser.search.region to GB.
  4. Restart and load a newtab.
    Expected: should see 7 rows of stories.
  5. Change browser.newtabpage.activity-stream.discoverystream.region-basic-config to "GB"
  6. Restart and load a newtab
    Expected: should see 1 row of stories.
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/64e46ee15d82 Make newtab stories 7 rows by default. r=gvn
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Comment on attachment 9179360 [details]
Bug 1665138 - Make newtab stories 7 rows by default.

Beta/Release Uplift Approval Request

  • User impact if declined: Similar to bug 1666892, once our global English feed experiment is done, we'll want it in 82.

It'll impact Q4 goals.

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: To test:
  1. Create a new profile in an English browser.
  2. Ensure you see newtab stories, and that you see 7 rows.
  3. Change browser.search.region to GB.
  4. Restart and load a newtab.
    Expected: should see 7 rows of stories.
  5. Change browser.newtabpage.activity-stream.discoverystream.region-basic-config to "GB"
  6. Restart and load a newtab
    Expected: should see 1 row of stories.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): A new pref, and a minor logic change, that reverses the logic for for what we did with the old pref, to do the opposite with the new pref.
  • String changes made/needed: none
Attachment #9179360 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

I have verified the following with the steps provided in comment 5 using Firefox Nightly 83.0a1 (Build ID: 20201005215809) en-US, en-GB, and en-CA on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:

  • The "Recommended by Pocket" section has 7 rows by default if the "browser.search.region" pref value is set to "GB".
  • The "Recommended by Pocket" section has 1 row if the "browser.search.region" pref value is set to "GB", the "browser.newtabpage.acttivity-stream.discoverystream.region-basic-config" pref value is set to "GB".
Status: RESOLVED → VERIFIED

Comment on attachment 9179360 [details]
Bug 1665138 - Make newtab stories 7 rows by default.

approved for 82.0b8

Attachment #9179360 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified the following with the steps provided in comment 5 using Firefox Beta 82.0b8 (Build ID: 20201006142214) en-US, en-GB, and en-CA on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:

  • The "Recommended by Pocket" section has 7 rows by default if the "browser.search.region" pref value is set to "GB".
  • The "Recommended by Pocket" section has 1 row if the "browser.search.region" pref value is set to "GB", the "browser.newtabpage.activity-stream.discoverystream.region-basic-config" pref value is set to "GB".
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: