Make 7 rows default
Categories
(Firefox :: New Tab Page, enhancement, P2)
Tracking
()
People
(Reporter: gsuntop, Assigned: thecount)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
make default the 7 rows since we’re now live in all markets with the 7 row layout
| Reporter | ||
Updated•5 years ago
|
| Reporter | ||
Updated•5 years ago
|
| Reporter | ||
Updated•5 years ago
|
| Reporter | ||
Updated•5 years ago
|
| Assignee | ||
Comment 1•5 years ago
|
||
[Tracking Requested - why for this release]: Similar to bug 1666892, once our global English feed experiment is done, we'll want this in 82.
| Assignee | ||
Comment 4•5 years ago
|
||
| Assignee | ||
Comment 5•5 years ago
|
||
To test:
- Create a new profile in an English browser.
- Ensure you see newtab stories, and that you see 7 rows.
- Change browser.search.region to GB.
- Restart and load a newtab.
Expected: should see 7 rows of stories. - Change browser.newtabpage.activity-stream.discoverystream.region-basic-config to "GB"
- Restart and load a newtab
Expected: should see 1 row of stories.
Comment 7•5 years ago
|
||
| bugherder | ||
| Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9179360 [details]
Bug 1665138 - Make newtab stories 7 rows by default.
Beta/Release Uplift Approval Request
- User impact if declined: Similar to bug 1666892, once our global English feed experiment is done, we'll want it in 82.
It'll impact Q4 goals.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: To test:
- Create a new profile in an English browser.
- Ensure you see newtab stories, and that you see 7 rows.
- Change browser.search.region to GB.
- Restart and load a newtab.
Expected: should see 7 rows of stories. - Change browser.newtabpage.activity-stream.discoverystream.region-basic-config to "GB"
- Restart and load a newtab
Expected: should see 1 row of stories.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): A new pref, and a minor logic change, that reverses the logic for for what we did with the old pref, to do the opposite with the new pref.
- String changes made/needed: none
| Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 9•5 years ago
|
||
I have verified the following with the steps provided in comment 5 using Firefox Nightly 83.0a1 (Build ID: 20201005215809) en-US, en-GB, and en-CA on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:
- The "Recommended by Pocket" section has 7 rows by default if the "browser.search.region" pref value is set to "GB".
- The "Recommended by Pocket" section has 1 row if the "browser.search.region" pref value is set to "GB", the "browser.newtabpage.acttivity-stream.discoverystream.region-basic-config" pref value is set to "GB".
Comment 10•5 years ago
|
||
Comment on attachment 9179360 [details]
Bug 1665138 - Make newtab stories 7 rows by default.
approved for 82.0b8
Comment 11•5 years ago
|
||
| bugherder uplift | ||
Comment 12•5 years ago
|
||
I have verified the following with the steps provided in comment 5 using Firefox Beta 82.0b8 (Build ID: 20201006142214) en-US, en-GB, and en-CA on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:
- The "Recommended by Pocket" section has 7 rows by default if the "browser.search.region" pref value is set to "GB".
- The "Recommended by Pocket" section has 1 row if the "browser.search.region" pref value is set to "GB", the "browser.newtabpage.activity-stream.discoverystream.region-basic-config" pref value is set to "GB".
Description
•