1709009 - Set media.navigator.mediadatadecoder_vpx_enabled to true for release

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Vincent Chernin]

Set media.navigator.mediadatadecoder_vpx_enabled to true for release. This enables enables FFMPEG VA-API decoding (Bug #1610199) support for WebRTC on Linux (Bug #1646329).

This was previously set to true in Bug #1665329 but was later reverted to false in Bug #1680313. This change should only be made if the regressions discussed in Bug #1680313 are addressed.

Comment 1

[Darkspirit]

Can this be shipped now that bug 1637658 is fixed?

(Jean-Yves Avenard [:jya] from bug 1637658 comment #37)

The code is disabled by pref in beta and release.

This patch will allow the pref to be enabled again, but no need for uplifting

The regressions of bug 1637658 (bug 1697316, bug 1713425, bug 1744481)
also occur with

• enabled and disabled media.navigator.mediadatadecoder_vpx_enabled,
• media.ffvpx.enabled:false media.rdd-ffvpx.enabled:false media.ffmpeg.enabled:false media.rdd-ffmpeg.enabled:false

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Let's look at it when VA-API bug are solved.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Regressions look solved. We're using that in Fedora for 2 years without issues so I guess it's time to enable it again.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1709009 [Linux] Use media decoders for WebRTC r?alwu

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dc2474a0ab6
Use media decoders for WebRTC r=alwu

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6dc2474a0ab6

Comment 7

[Sandor Molnar[:smolnar]]

Backed out changeset 6dc2474a0ab6 (bug 1709009) for landing during soft freeze.

Backout link: https://hg.mozilla.org/integration/autoland/rev/dade4a8107b975273127b3cec9d996ac9f14921e

Comment 8

[Marian-Vasile Laza]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/dade4a8107b975273127b3cec9d996ac9f14921e

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Will look at it, Thanks.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

I wonder how is that possible as we have enabled it for Nightly already. So what's the difference in Beta?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:stransky, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

I'll look at it later.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 14

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 15

[Robert Mader [:rmader]]

Martin, in looks like we could reland this by only allowing it on Linux, i.e. #if defined(NIGHTLY_BUILD) || defined(MOZ_WIDGET_GTK). WDYT?

Comment 16

[Martin Stránský [:stransky] (ni? me)]

Okay, let's do that after soft freeze.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9b0922a2ad4
[Linux] Use media decoders for WebRTC r=alwu

Comment 18

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/c9b0922a2ad4