1665383 - Enable NETWORK_EVENT and NETWORK_EVENT_STACK_TRACE resources by default

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P2)

Description

[Alexandre Poirot [:ochameau]]

This will be the last stone in order to start supporting remote frames and cross process navigations correctly in the netmonitor.

NETWORK_EVENT and NETWORK_EVENT_STACK_TRACE are preffed off behind devtools.testing.enableServerWatcherSupport:
https://searchfox.org/mozilla-central/source/devtools/server/actors/watcher.js#118-119

The goal of this bug is to enable them by default.
In order to do that, we have to fix all tests which starts failing when we enable them,
and before enabling them do all opportunistic changes to the resource payload so that we don't have to handle backward compat later on. bug 1654740 may be an example of this.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission MVP

Comment 2

[Alexandre Poirot [:ochameau]]

This bug is probably a meta, but is meant to be done in the scope of M2.

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1665383 - [devtools] Enable fission for network / network stacktrace events by default r=ochameau

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1665383 - [devtools] Query the nsIHttpChannel to make sure we get the sourceMapURL r=ochameau

This fixes browser_dbg-gc-sources.js test

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1665383 - [devtools] Handle netmonitor pause/resume on the client r=ochameau

Fixes browser_net_pause.js

Depends on D99620

Comment 6

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1665383 - [devtools] Add blockRequest/unblockRequest commands support r=ochameau

Fixes browser_jsterm_block_commands.js test

Depends on D99621

Comment 7

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1665383 - [devtools] Fix webconsole network events and stacktrace tests r=ochameau,nchevobbe

Fixes browser_webconsole_stubs_network_event.js
Fixes browser_webconsole_network_messages_stacktrace_console_initiated_request.js

Depends on D99622

Comment 8

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1665383 - [devtools] Only get targetFront for the watcherFront when a targetFront is not already set on the resource r=ochameau

Fixes browser_preloaded_newtab.js test
Fixes browser_aboutdebugging_devtoolstoolbox_target_destroyed.js test

Depends on D99623

Comment 9

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1665383 - [devtools] Enable NETWORK_EVENT and NETWORK_EVENT_STACKTRACE by default for fission r=ochameau

Enable NETWORK_EVENT and NETWORK_EVENT_STACKTRACE resources by default

Depends on D99624

Comment 10

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1665383 - [devtools] Disable blocking CSP test temprorarily r=ochameau

Disabling browser_net_block-csp.js as it fails with fission enabled.
Bug 1682153 details the issue, and the test would be enabled when this
bug is fixed.

Depends on D99625

Comment 11

[Phabricator Automation]

Comment on attachment 9192928 [details]
Bug 1665383 - [devtools] Query the nsIHttpChannel to make sure we get the sourceMapURL r=ochameau

Revision D99620 was moved to bug 1683107. Setting attachment 9192928 [details] to obsolete.

Comment 12

[Phabricator Automation]

Comment on attachment 9192932 [details]
Bug 1665383 - [devtools] Only get targetFront for the watcherFront when a targetFront is not already set on the resource r=ochameau

Revision D99624 was moved to bug 1683119. Setting attachment 9192932 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9192935 [details]
Bug 1665383 - [devtools] Disable blocking CSP test temprorarily r=ochameau

Revision D99626 was moved to bug 1683121. Setting attachment 9192935 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9192929 [details]
Bug 1665383 - [devtools] Handle netmonitor pause/resume on the client r=ochameau

Revision D99621 was moved to bug 1683152. Setting attachment 9192929 [details] to obsolete.

Comment 15

[Phabricator Automation]

Comment on attachment 9192930 [details]
Bug 1665383 - [devtools] Add blockRequest/unblockRequest commands support r=ochameau

Revision D99622 was moved to bug 1685262. Setting attachment 9192930 [details] to obsolete.

Comment 16

[Phabricator Automation]

Comment on attachment 9192931 [details]
Bug 1665383 - [devtools] Fix webconsole network events and stacktrace tests r=ochameau,nchevobbe

Revision D99623 was moved to bug 1686440. Setting attachment 9192931 [details] to obsolete.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34dd7e523954
[devtools] Enable NETWORK_EVENT and NETWORK_EVENT_STACKTRACE by default for fission r=ochameau

Comment 18

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1687205, Bug 1687192, Bug 1665383) for causing devtools failures in browser_net_block-csp.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=T6QMKagRSMO8eA18N1u1MA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&revision=812caf90c2c543956c7ea52b8632b61e0d707307&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-e10s%2Cdt9

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327030281&repo=autoland&lineNumber=3087

Backout: https://hg.mozilla.org/integration/autoland/rev/58b99a41151b6bfd8c7561ec47431dc284e17991

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/916c7c7f8bbc
[devtools] Enable NETWORK_EVENT and NETWORK_EVENT_STACKTRACE by default for fission r=ochameau

Comment 20

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/916c7c7f8bbc

Comment 21

[Chris Peterson [:cpeterson]]

This completed dt-fission-m3-mvp bug should have Fission Milestone M7 Beta.