1687192 - Multiple batched request updates with the same id override each other

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Hubert Boma Manilla (:bomsy)]

When enabling NETWORK_EVENT/NETWORK_EVENT_STACKTRACE in Bug 1665383. Browser_webconsole_network_messages_stacktrace_console_initiated_request.js test fails intermittently here https://searchfox.org/mozilla-central/rev/6feef3dcfce7e5c922093edde758330857ce2bb3/devtools/client/webconsole/test/browser/browser_webconsole_network_messages_stacktrace_console_initiated_request.js#45. This happens because the stacktrace trace is not shown.

After investigations i discovered that when we get multiple message updates with the same id's batched before the queue is flushed.
e.g

const updates = [
    { id: "server0.conn0.netEvent5" , data: { foo: "123" } },
    { id: "server0.conn0.netEvent5",  data: { bar: "456" } }
];

When redux updates the networkMessagesUpdateById state here https://searchfox.org/mozilla-central/source/devtools/client/webconsole/reducers/messages.js#574-598, the data of the second update overrides the first, instead of augment what is already there.
AR:
After state update

networkMessagesUpdateById = {
   "server0.conn0.netEvent5": { bar: "456" },
    ...
}

ER:
After state update

networkMessagesUpdateById = {
   "server0.conn0.netEvent5": { foo: "123", bar: "456" },
    ...
}

So in the test scenario above, the stacktrace from the first batch update gets overridden by the second batch update even though the second is not explicitly updating the stacktrace. This happens intermittenly because certain times the network response listener might send an update to the frontend from here https://searchfox.org/mozilla-central/rev/6feef3dcfce7e5c922093edde758330857ce2bb3/devtools/server/actors/network-monitor/network-response-listener.js#531-536

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1687192 - [devtools] Make sure multiple bacth updates with the same id does not override former r=nchevobbe

Depends on D102116

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/812caf90c2c5
[devtools] Make sure multiple batch updates with the same id does not override former r=nchevobbe

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1687205, Bug 1687192, Bug 1665383) for causing devtools failures in browser_net_block-csp.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=T6QMKagRSMO8eA18N1u1MA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&revision=812caf90c2c543956c7ea52b8632b61e0d707307&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-e10s%2Cdt9

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327030281&repo=autoland&lineNumber=3087

Backout: https://hg.mozilla.org/integration/autoland/rev/58b99a41151b6bfd8c7561ec47431dc284e17991

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d1308169ca6
[devtools] Make sure multiple bacth updates with the same id does not override former r=nchevobbe

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7d1308169ca6